-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cOdiglet to use criwrapper to create ic #2015
Merged
tamirdavid1
merged 43 commits into
odigos-io:main
from
tamirdavid1:odiglet-to-use-criwrapper-to-create-ic
Dec 26, 2024
Merged
Changes from 30 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
0d646fd
feat: initial commit - identify where env vars from
tamirdavid1 341dda6
feat: test on odiglet main to be deleted
tamirdavid1 10c8c79
feat: initial commit
tamirdavid1 5f879c1
chore: remove makefile addition + comment
tamirdavid1 59579f3
chore: adjust comments and change how grpc connectec
tamirdavid1 c410796
chore: remove unused ctx
tamirdavid1 a666ecd
feat: move cri connect out of go routine
tamirdavid1 1f77020
fix: rebase
tamirdavid1 6ab4aaa
fix: rebase
tamirdavid1 68e3def
fix: rebase
tamirdavid1 f4aa885
chore: remove newline
tamirdavid1 7a83e2b
fix: run make go-mod-tidy
tamirdavid1 4b37c04
fix: use-kube-manager-options
tamirdavid1 3fef066
fix: remove not used observedWorkloadGeneration
tamirdavid1 a071d5d
fix: remove odigos env var in the instrumentationconfig
tamirdavid1 16a55ab
feat: add test that PYTHONPATH exists in dockerfile for inventory
tamirdavid1 03bb7e7
fix: change PYTHONPATH value
tamirdavid1 b2978f7
feat: remove tests
tamirdavid1 f0259b0
fix: rebase
tamirdavid1 6df6b2a
fix: rebase conflicts
tamirdavid1 8eaa3bd
fix: rebasing
tamirdavid1 722a49e
fix: rebasing
tamirdavid1 8fb407c
fix: based on PR comments
tamirdavid1 1c14d62
feat: remove not used runtime_details/utils.go anymore
tamirdavid1 2a7b28c
fix: rebase and fix conclits
tamirdavid1 3262150
fix: run make generate && make manifests
tamirdavid1 57ff741
fix: remove no-cache from Makefile > added for tests proposes
tamirdavid1 68967e0
chore: rename EnvVarsFromDockerFile > EnvFromContainerRuntime
tamirdavid1 0d1f240
chore: remove conflicts
tamirdavid1 ace5022
chore: run make go-mod-tidy
tamirdavid1 19edc24
chore: based on comment use main ctx in criwrapper connect
tamirdavid1 bdde925
chore: following pr comments
tamirdavid1 3053147
chore: validate extractContainerID returned value
tamirdavid1 673c395
chore: handle grpc close error if back
tamirdavid1 8a410d3
chore: rename warpper to client based on PR comments
tamirdavid1 9dab738
chore: comment describing 3 added attributes added
tamirdavid1 05e1f53
chore: use 1 pods in instrumentation config controller to avoid itera…
tamirdavid1 c679274
chore: add comments + timeout for containerStatus request
tamirdavid1 717dfb7
chore: run make sync-helm-crd
tamirdavid1 7db80ad
chore: start to work on if cri fail case - TBC
tamirdavid1 bd9bf89
fix: break in case case processing state marked as fail in cri fallback
tamirdavid1 80737f1
chore: change fmt.errors to dedicated error
tamirdavid1 b8b9228
Merge branch 'main' into odiglet-to-use-criwrapper-to-create-ic
tamirdavid1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 1 addition & 10 deletions
11
api/generated/odigos/applyconfiguration/odigos/v1alpha1/instrumentationconfigstatus.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
45 changes: 39 additions & 6 deletions
45
api/generated/odigos/applyconfiguration/odigos/v1alpha1/runtimedetailsbycontainer.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isnt status a better place for error messages instead of spec?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
potentially could be some error on specific container, we will have to verify this before instrumenting a container from the webhook