feat: record installation method into odigos-deployment #2184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonFed
approved these changes
Jan 11, 2025
BenElferink
added a commit
that referenced
this pull request
Jan 12, 2025
…#2185) Following up with a UI update in reference to #2184 --- This pull request introduces several changes to the `frontend/graph` and `frontend/webapp` components to add support for `tier` and `installationMethod` fields in the `OdigosAnalyze` structure. The most important changes include updates to the GraphQL schema, resolvers, and TypeScript definitions. ### GraphQL Schema and Resolvers: * Added `tier` and `installationMethod` fields to the `OdigosAnalyze` struct in `frontend/graph/generated.go` and updated the corresponding complexity functions. [[1]](diffhunk://#diff-4bacf1f13939a5c243f3f83d21f4560b331d13667d81ea5945ed1f57ddb205f2R327-R333) [[2]](diffhunk://#diff-4bacf1f13939a5c243f3f83d21f4560b331d13667d81ea5945ed1f57ddb205f2R1770-R1776) [[3]](diffhunk://#diff-4bacf1f13939a5c243f3f83d21f4560b331d13667d81ea5945ed1f57ddb205f2R1812-R1818) * Implemented resolver functions for the new `tier` and `installationMethod` fields in `frontend/graph/generated.go`. * Updated the `OdigosAnalyze` query to include the new fields in `frontend/graph/generated.go`. [[1]](diffhunk://#diff-4bacf1f13939a5c243f3f83d21f4560b331d13667d81ea5945ed1f57ddb205f2R13327-R13330) [[2]](diffhunk://#diff-4bacf1f13939a5c243f3f83d21f4560b331d13667d81ea5945ed1f57ddb205f2R20112-R20121) ### TypeScript and GraphQL Queries: * Updated the `OdigosAnalyze` type definition to include `tier` and `installationMethod` in `frontend/graph/model/models_gen.go` and `frontend/graph/schema.graphqls`. [[1]](diffhunk://#diff-642ccd7ed71fdfa394bd7f7fd99c9c33e20ff18c876a91cb989d379a44390469R389-R390) [[2]](diffhunk://#diff-bc07b91dedd1782d9ddbbb6374ad97c7604f9a267de5174645723d863c732f80R547-R548) * Modified the `convertOdigosToGQL` function to map the new fields in `frontend/services/describe/odigos_describe/odigos_describe.go`. * Extended the GraphQL query `DESCRIBE_ODIGOS` to fetch `tier` and `installationMethod` in `frontend/webapp/graphql/queries/describe.ts`. * Updated the `useDescribeOdigos` hook to handle the new fields in `frontend/webapp/hooks/describe/useDescribeOdigos.ts`. * Added `tier` and `installationMethod` to the `OdigosAnalyze` interface in `frontend/webapp/types/describe.ts`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds "instllation method" to
odigos-deploymentconfig map, so we can reliably know if the current installation is deployed via "helm" or "odigos-cli".We can later use this info to warn or block usages which we do not support and might end up with a broken deployment or odigos.
This PR also adds the installation method and tier to the describe cli command: