Adjust indexing for content of InvestStorageBlock #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust indexing to be same as for content of storage without investment.
This shifts the inital time step to be consistent with a non-invest storage for models allowing only upfront-invest. Known issues: For multi-period models, the inconsistent behaviour persists because the TIMEINDEX does not make a difference between TIMEPOINTS and TIMESTEPS.
As there is one more tim step, there is one more variable.
The attributes exist for all of the storages in the set.
|
I pulled this into #1080 to fix it without having to rewrite lp files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1030
The file has a lot of duplication and should be reworked. I try to provide a quick fix without changing too much but I failed once already.
Additional todos I think that are needed because of my experience in #1038.