Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust indexing for content of InvestStorageBlock #1039

Merged
merged 5 commits into from
Aug 20, 2024

Commits on Jan 18, 2024

  1. Adjust indexing for content of InvestStorageBlock

    Adjust indexing to be same as for content of storage without investment.
    p-snft committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    8caffe7 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Fix initial time step of for InvestStorage

    This shifts the inital time step to be consistent with a non-invest
    storage for models allowing only upfront-invest.
    
    Known issues: For multi-period models, the inconsistent behaviour persists
    because the TIMEINDEX does not make a difference between TIMEPOINTS and
    TIMESTEPS.
    p-snft committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    1597318 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1e62bd1 View commit details
    Browse the repository at this point in the history
  3. Fix storage dump test

    As there is one more tim step, there is one more variable.
    p-snft committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    d9f7012 View commit details
    Browse the repository at this point in the history
  4. Remove outdated comments

    The attributes exist for all of the storages in the set.
    p-snft committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    ccd1b5d View commit details
    Browse the repository at this point in the history