Fix test errors

ohsu-comp-bio · Sep 25, 2024 · 194c759 · 194c759
1 parent 5934aa5
commit 194c759
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/.github/workflows/s3.yaml b/.github/workflows/s3.yaml
@@ -26,7 +26,7 @@ jobs:
 
       - uses: actions/download-artifact@v4
         with:
-          name: funnelBin
+          name: funnel
 
       - name: Start Funnel server
         run: |

diff --git a/storage/anonymous_get_test.go b/storage/anonymous_get_test.go
@@ -41,6 +41,10 @@ func TestAmazonS3AnonymousGet(t *testing.T) {
 		endpoint: "",
 	}
 
+	// AWS S3 Public Datasets:
+	// - https://registry.opendata.aws/
+	// 1000 Genomes Public Dataset:
+	// - https://registry.opendata.aws/1000-genomes/
 	_, err = store.Get(context.Background(), "s3://1000genomes/README.analysis_history", "_test_download/README.analysis_history")
 	if err != nil {
 		t.Error("Error downloading file:", err)
@@ -55,7 +59,11 @@ func TestGoogleStorageAnonymousGet(t *testing.T) {
 
 	store := &GoogleCloud{svc}
 
-	_, err = store.Get(context.Background(), "gs://uspto-pair/applications/07820856.zip", "_test_download/07820856.zip")
+	// Google Cloud Public Datasets:
+	// - https://cloud.google.com/datasets?hl=en
+	// Broad Institute Public Dataset:
+	// - https://console.cloud.google.com/storage/browser/gcp-public-data--broad-references;tab=objects?prefix=&forceOnObjectsSortingFiltering=false
+	_, err = store.Get(context.Background(), "gs://gcp-public-data--broad-references/C.elegans/WBcel235/README.txt", "_test_download/README.txt")
 	if err != nil {
 		t.Error("Error downloading file:", err)
 	}

diff --git a/tes/utils_test.go b/tes/utils_test.go
@@ -16,7 +16,7 @@ func TestBase64Encode(t *testing.T) {
 		},
 	}
 
-	expected := "ewogICJleGVjdXRvcnMiOiBbCiAgICB7CiAgICAgICJjb21tYW5kIjogWwogICAgICAgICJlY2hvIiwKICAgICAgICAiaGVsbG8gd29ybGQiCiAgICAgIF0sCiAgICAgICJpbWFnZSI6ICJhbHBpbmUiCiAgICB9CiAgXSwKICAiaWQiOiAidGFzazEiCn0="
+	expected := "ewogICJleGVjdXRvcnMiOiAgWwogICAgewogICAgICAiY29tbWFuZCI6ICBbCiAgICAgICAgImVjaG8iLAogICAgICAgICJoZWxsbyB3b3JsZCIKICAgICAgXSwKICAgICAgImltYWdlIjogICJhbHBpbmUiCiAgICB9CiAgXSwKICAiaWQiOiAgInRhc2sxIgp9"
 
 	encoded, err := Base64Encode(task)
 	if err != nil {