E2E protocol #1521
Merged
E2E protocol #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
taoeffect
commented
Mar 29, 2023
•
taoeffect
commented
- Closes Key management #92
- Closes Implement Keychain interface #112
- Closes Clean up and improve code related to calling 'gi.actions/identity/login' #1765
- Closes Make group activity history private #839
- Closes User accounts and real login #852
taoeffect
commented
Jun 3, 2023
taoeffect
commented
Jun 3, 2023
taoeffect
commented
Jun 3, 2023
Comment on lines
+893
to
+897
| script.text = source | ||
| // NOTE: this will work if the file route adds .header('Content-Type', 'application/javascript') | ||
| // script.src = `${this.config.connectionURL}/file/${hash}` | ||
| // this results in: "SyntaxError: import declarations may only appear at top level of a module" | ||
| // script.innerHTML = `(function () { | ||
| // script.text = `(function () { |
taoeffect
commented
Jun 3, 2023
taoeffect
commented
Jun 11, 2023
| if (key.foreignKey) { | ||
| const fkUrl = new URL(key.foreignKey) | ||
| const foreignContract = fkUrl.pathname | ||
| const foreignKeyName = fkUrl.searchParams.get('keyName') |
There was a problem hiding this comment.
As a user-provided parameter, can this be abused in any way?
There was a problem hiding this comment.
I'm not sure that this is 'user-provided' any more than the rest of the parameters, but I guess it would result in perhaps syncing the wrong key at worst.
taoeffect
commented
Jul 4, 2023
… so it can send push to a particular endpoint
…#1763) * feat: sync missing identity contracts after joining group * chore: remove IIFE * chore: resolved feedback
E2e protocol ricardo
… way to assign globalThis.crypto
* add markdown-it pkg to the project and make sure it works * try slack-style markdown plugin * optimise the convertToMarkdown() function * switch from markdown-it to marked (zero-dependency pkg) * define a custom renderer function that converts *string* to <strong>string</strong> * style the <code> and <pre><code></code></pre> in the generated markdown outcome * add more style declarations for markdown elements * enable <del> tag / specify target='_blank' to <a> tag output * add various call-to-action btns for transforming to markdown in SendArea.vue * add a couple of more cta btns * implement transformTextSelectionToMarkdown() method * create injectOrStripSpecialChar() func for logic that injects special characters * implment inject link element to the target string * move the link cta to the last in the line * move the primary call-to-actions next to the send btn / add style ctas to the edit mode too * fix issue with the nested markdown styles / switch gfm on * work on more feedback items * delete the test file * work on more change requests
e2e protocol ricardo
taoeffect
commented
Jan 25, 2024
This reverts commit 4348366.
taoeffect
commented
Jan 25, 2024
Comment on lines
+230
to
+231
| GIMessage, | ||
| JSON, |
There was a problem hiding this comment.
Why are these here?
EDIT: will be cleared out in a separate PR
corrideat
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.