fix: menu button not allowing falsey children #1999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinGhadyani-Okta
requested review from
benschell-okta,
chrispulsinelli-okta and
a team
as code owners
There was a problem hiding this comment.
I think this file diff was doubly applied
There was a problem hiding this comment.
Naw, the props were alphabetized since its creation.
Fixed: ba388da.
KevinGhadyani-Okta
force-pushed
the
kg/menu-button-falsy-children
branch
from
ba388da
to
f05d307
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OKTA-636204
Summary
Menu Button didn't accept
nullas a value for conditional items.@chrispulsinelli-okta did all the code. I just moved it to a new branch.
Previous PR: #1934
Testing & Screenshots
N/A