Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: menu button not allowing falsey children #1999

Merged
merged 4 commits into from
Oct 13, 2023
Merged

fix: menu button not allowing falsey children #1999

merged 4 commits into from
Oct 13, 2023

Commits on Oct 12, 2023

  1. fix: readd isDisabled prop to Button

    @KevinGhadyani-Okta
    KevinGhadyani-Okta committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    3d95409 View commit details
    Browse the repository at this point in the history

  2. Fix: MenuButton accepts falsy children

    @chrispulsinelli-okta @KevinGhadyani-Okta
    chrispulsinelli-okta authored and KevinGhadyani-Okta committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    7e0735f View commit details
    Browse the repository at this point in the history

  3. chore: pr feedback

    @chrispulsinelli-okta @KevinGhadyani-Okta
    chrispulsinelli-okta authored and KevinGhadyani-Okta committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    0483e7f View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. fix: duplicate props on MenuItem

    @KevinGhadyani-Okta
    KevinGhadyani-Okta committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    f05d307 View commit details
    Browse the repository at this point in the history