Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data view, stack, and table #2267

Merged
merged 15 commits into from
Jul 2, 2024
Merged

Data view, stack, and table #2267

merged 15 commits into from
Jul 2, 2024

Conversation

jordankoschei-okta
Copy link
Contributor

@jordankoschei-okta jordankoschei-okta commented Jun 18, 2024

REPLACE_WITH_JIRA_TICKET_NUMBER

Summary

Testing & Screenshots

  • I have confirmed this change with my designer and the Odyssey Design Team.

@jordankoschei-okta jordankoschei-okta requested a review from a team as a code owner June 18, 2024 01:07
@jordankoschei-okta
Copy link
Contributor Author

Extension of #2260 to account for the issue I had with my commits not being verified. (They are now!)

Copy link
Contributor

@KevinGhadyani-Okta KevinGhadyani-Okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only got 3/4ths of the way through. Stopped at TableContent.tsx.

Copy link
Contributor

@KevinGhadyani-Okta KevinGhadyani-Okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing my request for changes.

Copy link
Contributor

@KevinGhadyani-Okta KevinGhadyani-Okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No change is API-specific at this point. As long as we have a follow-up ticket to address the rest of these changes, this is good to go!

@oktapp-aperture-okta oktapp-aperture-okta bot merged commit 19bc10b into main Jul 2, 2024
2 checks passed
@oktapp-aperture-okta oktapp-aperture-okta bot deleted the dataview-v2 branch July 2, 2024 14:10
stephanieyoshimoto-okta pushed a commit that referenced this pull request Jul 15, 2024
OKTA-726074 feat: add DataComponent work
feat: add DataComponent stories
feat: add enableWrapping for backwards compat with hasTextWrapping
refactor: alphabetize all the props
refactor: reorganize the imports
refactor: adding translations
refactor: remove negative margin from card accessory
refactor: convert sx to styled wherever needed
refactor: fix some missing callback deps
feat: adding row expansion to stack cards
feat: add proper open mechanism to stack cards
feat: updating table translations
refactor: replace Box with MuiBox for native flex support
refactor: implement all code review feedback
feat: add docs for Data View
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants