-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data view, stack, and table #2267
Conversation
Extension of #2260 to account for the issue I had with my commits not being verified. (They are now!) |
packages/odyssey-react-mui/src/labs/DataComponents/BulkActionsMenu.tsx
Outdated
Show resolved
Hide resolved
packages/odyssey-react-mui/src/labs/DataComponents/BulkActionsMenu.tsx
Outdated
Show resolved
Hide resolved
packages/odyssey-react-mui/src/labs/DataComponents/DataTable.tsx
Outdated
Show resolved
Hide resolved
packages/odyssey-react-mui/src/labs/DataComponents/DataView.tsx
Outdated
Show resolved
Hide resolved
packages/odyssey-react-mui/src/labs/DataComponents/LayoutSwitcher.tsx
Outdated
Show resolved
Hide resolved
packages/odyssey-react-mui/src/labs/DataComponents/RowActions.tsx
Outdated
Show resolved
Hide resolved
packages/odyssey-react-mui/src/labs/DataComponents/StackCard.tsx
Outdated
Show resolved
Hide resolved
packages/odyssey-react-mui/src/labs/DataComponents/StackCard.tsx
Outdated
Show resolved
Hide resolved
packages/odyssey-react-mui/src/labs/DataComponents/StackCard.tsx
Outdated
Show resolved
Hide resolved
packages/odyssey-react-mui/src/labs/DataComponents/StackContent.tsx
Outdated
Show resolved
Hide resolved
packages/odyssey-react-mui/src/labs/DataComponents/StackContent.tsx
Outdated
Show resolved
Hide resolved
...ages/odyssey-storybook/src/components/odyssey-labs/DataComponents/DataComponents.stories.tsx
Show resolved
Hide resolved
packages/odyssey-react-mui/src/labs/DataComponents/TableContent.tsx
Outdated
Show resolved
Hide resolved
packages/odyssey-react-mui/src/labs/DataComponents/TableContent.tsx
Outdated
Show resolved
Hide resolved
packages/odyssey-react-mui/src/labs/DataComponents/TableContent.tsx
Outdated
Show resolved
Hide resolved
packages/odyssey-react-mui/src/labs/DataComponents/TableContent.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only got 3/4ths of the way through. Stopped at TableContent.tsx
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing my request for changes.
packages/odyssey-react-mui/src/labs/DataComponents/useFilterConversion.ts
Show resolved
Hide resolved
packages/odyssey-react-mui/src/labs/DataComponents/useFilterConversion.ts
Show resolved
Hide resolved
packages/odyssey-react-mui/src/labs/DataComponents/useFilterConversion.ts
Show resolved
Hide resolved
packages/odyssey-storybook/src/components/odyssey-labs/DataComponents/dataFunctions.ts
Show resolved
Hide resolved
packages/odyssey-storybook/src/components/odyssey-labs/DataComponents/dataFunctions.ts
Show resolved
Hide resolved
packages/odyssey-storybook/src/components/odyssey-labs/DataComponents/dataFunctions.ts
Show resolved
Hide resolved
packages/odyssey-storybook/src/components/odyssey-labs/DataComponents/dataFunctions.ts
Show resolved
Hide resolved
packages/odyssey-storybook/src/components/odyssey-mui/Card/Card.stories.tsx
Show resolved
Hide resolved
packages/odyssey-storybook/src/components/odyssey-mui/DataTable/DataTable.stories.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No change is API-specific at this point. As long as we have a follow-up ticket to address the rest of these changes, this is good to go!
OKTA-726074 feat: add DataComponent work feat: add DataComponent stories feat: add enableWrapping for backwards compat with hasTextWrapping refactor: alphabetize all the props refactor: reorganize the imports refactor: adding translations refactor: remove negative margin from card accessory refactor: convert sx to styled wherever needed refactor: fix some missing callback deps feat: adding row expansion to stack cards feat: add proper open mechanism to stack cards feat: updating table translations refactor: replace Box with MuiBox for native flex support refactor: implement all code review feedback feat: add docs for Data View
REPLACE_WITH_JIRA_TICKET_NUMBER
Summary
Testing & Screenshots