Upgrade VCR to v3 #1650
Merged
Upgrade VCR to v3 #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
monde
commented
Jul 27, 2023
•
monde
commented
- Upgrades our VCR to version 3 that allows more tests to be recorded
- Re-record OIE and Classic org cassettes
- Fix some tests
- Smooth out some of the TF plugin framework and Okta SDK v2/v3 code
MikeMondragon-okta
force-pushed
the
vcr_v3_upgrade
branch
7 times, most recently
from
35e5ae5
to
d31b416
Compare
MikeMondragon-okta
force-pushed
the
vcr_v3_upgrade
branch
2 times, most recently
from
f0939e6
to
1ea80e7
Compare
OKTA_VCR_TF_ACC=play make testacc TEST=./okta TESTARGS='-run=TestAccDataSourceOktaBrand_read' OKTA_VCR_CASSETTE=mm-oie-2022-10-07-max OKTA_VCR_TF_ACC=play make testacc TEST=./okta TESTARGS='-run=TestAccDataSourceOktaBrand_read' OKTA_VCR_CASSETTE=mm-classic-2022-10-04 OKTA_VCR_TF_ACC=play TF_ACC=1 go test -tags unit -mod=readonly -test.v -run ^TestAccDataSourceOktaBrand_read$ ./okta OKTA_VCR_TF_ACC=play TF_ACC=1 go test -tags unit -mod=readonly -test.v -run ^TestAccDataSourceOktaBrand_read$ ./okta
Removing v2 VCR cassettes that have had their tests removed or are no longer passing. Recorded 33 new cassettes for passing tests. 199 VCR cassettes for a classic org re-record OIE and Classic org VCR cassettes.
lucky of a request is made outside of VCR's http transport.
…CamelCaseResourceName]_[extra]"
MikeMondragon-okta
force-pushed
the
vcr_v3_upgrade
branch
from
2c31da0
to
29055c6
Compare
duytiennguyen-okta
approved these changes
Aug 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.