Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade VCR to v3 #1650

Merged
merged 24 commits into from
Aug 18, 2023
Merged

Upgrade VCR to v3 #1650

merged 24 commits into from
Aug 18, 2023

Commits on Aug 15, 2023

  1. Upgrade VCR to v3

    @monde
    monde committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    5119f29 View commit details
    Browse the repository at this point in the history

  2. Touch up on playing single or multiple cassettes. 

    OKTA_VCR_TF_ACC=play make testacc TEST=./okta TESTARGS='-run=TestAccDataSourceOktaBrand_read'
OKTA_VCR_CASSETTE=mm-oie-2022-10-07-max OKTA_VCR_TF_ACC=play make testacc TEST=./okta TESTARGS='-run=TestAccDataSourceOktaBrand_read'
OKTA_VCR_CASSETTE=mm-classic-2022-10-04 OKTA_VCR_TF_ACC=play TF_ACC=1 go test -tags unit -mod=readonly -test.v -run ^TestAccDataSourceOktaBrand_read$ ./okta
OKTA_VCR_TF_ACC=play TF_ACC=1 go test -tags unit -mod=readonly -test.v -run ^TestAccDataSourceOktaBrand_read$ ./okta
    @monde
    monde committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    9ee7973 View commit details
    Browse the repository at this point in the history

  3. Parallel tests weren't being captured in VCR recording.

    @monde
    monde committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    9f52ec6 View commit details
    Browse the repository at this point in the history

  4. One would expect TestMain be defined in provider_test.go rather than 

    some other file.
    @monde
    monde committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    c5e036f View commit details
    Browse the repository at this point in the history

  5. Unused code, sdk client sets User-Agent

    @monde
    monde committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    d79c9a2 View commit details
    Browse the repository at this point in the history

  6. Refactor naming conventions on SDK clients and clean up to benefit 

    testing.
    @monde
    monde committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    01403e8 View commit details
    Browse the repository at this point in the history

  7. Naming clean up in tests.

    @monde
    monde committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    72e15fd View commit details
    Browse the repository at this point in the history

  8. re-record VCR cassettes in V3 format. 

    Removing v2 VCR cassettes that have had their tests removed or are no
longer passing.

Recorded 33 new cassettes for passing tests.

199 VCR cassettes for a classic org

re-record OIE and Classic org VCR cassettes.
    @monde
    monde committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    5bba13a View commit details
    Browse the repository at this point in the history

  9. Toggle VCR setting on recording latency so playback can be fast.

    @monde
    monde committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    8965332 View commit details
    Browse the repository at this point in the history

  10. Erase old VCR cassettes.

    @monde
    monde committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    a79a0dd View commit details
    Browse the repository at this point in the history

  11. Make sure bad hostnames are recorded in VCR so replay is sure to not get 

    lucky of a request is made outside of VCR's http transport.
    @monde
    monde committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    4b82b6f View commit details
    Browse the repository at this point in the history

  12. default test args are verbose.

    @monde
    monde committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    2223622 View commit details
    Browse the repository at this point in the history

  13. Refine VCR matcher and hook

    @monde
    monde committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    e8df029 View commit details
    Browse the repository at this point in the history

  14. Rename test functions in the idiom "TestAcc[DataSource|Resource]Okta[… 

    …CamelCaseResourceName]_[extra]"
    @monde
    monde committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    49b8ca8 View commit details
    Browse the repository at this point in the history

  15. check err first

    @monde
    monde committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    b5c0e91 View commit details
    Browse the repository at this point in the history

  16. Use manager's seed for random value.

    @monde
    monde committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    cffbca5 View commit details
    Browse the repository at this point in the history

  17. helper for tests that shouldn't be vcr'd

    @monde
    monde committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    5dee6ba View commit details
    Browse the repository at this point in the history

  18. VCR smoke tests must pass on merges and releases.

    @monde
    monde committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    58a9509 View commit details
    Browse the repository at this point in the history

  19. Tidy up merging in master

    @monde
    monde committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    2f906a9 View commit details
    Browse the repository at this point in the history

  20. Tidy up domain related tests.

    @monde
    monde committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    29055c6 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. OIE and Classic cassettes

    @monde
    monde committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    89909a8 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. Minor clean up on test set up. Need to finish VCR refactor when using a 

    tf mux server.
    @monde
    monde committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    c898e6c View commit details
    Browse the repository at this point in the history

  2. vet'd code

    @monde
    monde committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    bcd86d7 View commit details
    Browse the repository at this point in the history

  3. Refine reminder about VCR & parallel tests

    @monde
    monde committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    aeec3f3 View commit details
    Browse the repository at this point in the history