Handle multiple apps returned by SAML app data source, where one app exactly matches. #1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exactly matches. In the case where there are two apps: "MyApp" and "MyApp 2". If the data source for saml apps queried with label "MyApp", if the API returns "MyApp 2" as the first app in the list, the data source will fail. This change now iterate through all of the apps returned and returning an exact match, if "label" has been specified.
|
@MatthewJohn Thanks. We will review it |
|
Thanks @duytiennguyen-okta :) |
duytiennguyen-okta
requested changes
Feb 23, 2024
| for _, appItx := range appList { | ||
| if appItx.Label == filters.Label { | ||
| app = appItx | ||
| foundMatch = true |
There was a problem hiding this comment.
It should break here, similar to https://github.com/okta/terraform-provider-okta/blob/master/okta/data_source_okta_app.go#L111?
There was a problem hiding this comment.
Oh course, yes, apologies!
|
If you're ok with the suggestion, I will bring the PR in and update it @MatthewJohn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case where there are two apps: "MyApp" and "MyApp 2".
If the data source for saml apps queried with label "MyApp" and the API returns "MyApp 2" as the first app in the list, the data source will fail.
This change now iterates through all of the apps returned and returning an exact match, if "label" has been specified.