Replace VLC with OMXPlayer #19
Conversation
omarcostahamido
requested review from
omarcostahamido,
rustberry,
SSSSam141 and
xrk-git
There was a problem hiding this comment.
it seems to me that you are very much aware that some work is still needed, not only to fix the several todo items that you wrote on the code (thanks), but also to make it even be a thing that appears on the readme - which, I will stress that again, is very important!
If you all decide it is better to merge in order to split work after that, go for it.
But I want to see some readme updates asap. Doesn't have to be the final thing (it would be hard to do so). But something is better than nothing. It can always be improved later.
There was a problem hiding this comment.
I remember everyone agreed to deprecate VLC and move on to fully adopt OMXplayer.
In that sense I propose this PR to already include the deletion of these files doc_vlc_-I_rc.txt doc_vlc_-h_--advanced.txt and pvm_alt.py, as well as possibly not to create an additional pvm_omx.py but instead make that the new pvm.py
Additionally, README.md needs to be updated accordingly 😃
edit: remove also python-vlc from the requirements.txt
Edited OP so that it will close #11 at the same time.
|
Remove the content about VLC and rename pvm_omx |
There was a problem hiding this comment.
@KaneBetter thx for the updates.
Again, I'm ok with it being merged if others also agree.
Also, let's try to clear this temporary TODO list on the readme asap, and turn that into issues to be assigned and addressed 😉
| @@ -3,6 +3,12 @@ Pi Video Machine - a scalable, synchronized, and networked-controlled, raspberry | |||
|
|
|||
|
|
|||
| ### { This is a work in progress } | |||
|
|
|||
| - TODO: rename the variable | |||
There was a problem hiding this comment.
@KaneBetter what variable?
There was a problem hiding this comment.
There was a problem hiding this comment.
Ok, I see what you did now. You just transcribed all the todo comment lines into the readme.
| - TODO: rename the variable | ||
| - TODO: rewrite logging | ||
| - TODO: rewrite logic between commands | ||
| - TODO: Create another python file to control two display |
There was a problem hiding this comment.
this sounds more like a latter version of the project - the end goal (last milestone) -, rather than an alternative version?
things to decide when we get to that point include:
- is it using 2 UDP servers on different ports?
- is it possible to detect with rpi device has 1 or 2 screens connected?
of course, I am not saying that you shouldn't start working on it, I am just saying that it might turn out to be the final version of the project, and not an alternative python script 😄
There was a problem hiding this comment.
Yes, we need to think about the use case in more detail in the later milestone.
* Replace VLC with OMXPlayer (#19) * Used Omxplayer in system 10 * Add shell script for build omxplayer * Add set rate feature * Added logging format and TODO list * Remove vlc and change README.md * Lib folder (#23) - this fixes #21 - users will only have to open `pvm.maxproj` now * move max files into `lib` folder * Create pvm.maxproj * Update README.md - added reference to `pvm.maxproj` - moved long explanation of the max control interface to the structure section. Co-authored-by: Kane <[email protected]>
* Used Omxplayer in system 10 * Add shell script for build omxplayer * Add set rate feature * Added logging format and TODO list * Remove vlc and change README.md
Close #11
Fix #16
Future scope of work: