Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace VLC with OMXPlayer #19

Merged
merged 7 commits into from
Oct 25, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@ Pi Video Machine - a scalable, synchronized, and networked-controlled, raspberry


### { This is a work in progress }

- TODO: rename the variable
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KaneBetter what variable?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I see what you did now. You just transcribed all the todo comment lines into the readme.

- TODO: rewrite logging
- TODO: rewrite logic between commands
- TODO: Create another python file to control two display
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this sounds more like a latter version of the project - the end goal (last milestone) -, rather than an alternative version?
things to decide when we get to that point include:

  • is it using 2 UDP servers on different ports?
  • is it possible to detect with rpi device has 1 or 2 screens connected?

of course, I am not saying that you shouldn't start working on it, I am just saying that it might turn out to be the final version of the project, and not an alternative python script 😄

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we need to think about the use case in more detail in the later milestone.

- TODO: create a isFileSet flag

## Requirements

Expand Down Expand Up @@ -82,17 +88,15 @@ Note: this is assuming that you clone this repo on your raspberry pi in the main
_ | filename | description
---------: | :----------- | :---------------------------------------------------
**device** | `pvm.py` | main python script, this runs on each pi device
_ | `pvm_alt.py` | (to be removed) alternative main python script, this runs on each pi device. Does not use `python-vlc`, instead controls vlc from a terminal stdin
**control** | `max-init.txt` | this file can make control patch setup faster
_ | `pvm.maxpat` | main control patch. controls 6 pvm devices at the same time
_ | `pvm_control.maxpat` | abstraction with the control patch GUI to be embedded as a bpatcher
_ | `pvm_init.maxpat` | abstraction responsible for parsing the `max-init.txt` file
_ | `pvm_send.maxpat` | abstraction for OSC sending. Arguments: _ip port_. Attributes: `@ip` `@port`
_ | `pvm_warmup.maxpat` | abstraction for interpolating playback rates, to be embedded as a bpatcher
_ | `host.py` | (to be removed) control a remote device using a python script instead
**others** | `doc_vlc_-I_rc.txt` | help log from `vlc` interactive mode CLI
_ | `doc_vlc_-h_--advanced.txt` | help log from `vlc` advanced options CLI
_ | `launch.sh` | shell script to start `pvm.py` with one _click_
**others** | `launch.sh` | shell script to start `pvm.py` with one _click_
_ | `build_omxplayer.sh` | shell script to build `omxplayer` with one _click_


## Helpful links
Expand Down
73 changes: 0 additions & 73 deletions doc_vlc_-I_rc.txt

This file was deleted.

Loading