Some more small fixes to cherry-pick. #1294
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The travis issue is not an issue. |
Daniel-KM
force-pushed
the
fix/ongoing
branch
from
a87cd67 to
01af7aa
Compare
|
A new fix for the browse preview for media. |
Daniel-KM
force-pushed
the
fix/ongoing
branch
from
de5e355 to
d7d8c4f
Compare
Daniel-KM
force-pushed
the
fix/ongoing
branch
from
b5bac74 to
a4aebe6
Compare
|
The branch has been rebased to remove all included commits. |
|
Some small improvements. |
zerocrates
reviewed
Nov 19, 2018
| <?php else: ?> | ||
| <?php echo $this->translate('[no log]') ?> | ||
| <?php echo $translate('[no log]'); ?> |
There was a problem hiding this comment.
This seems to have been left behind from one of the "convert to $translate" commits.
There was a problem hiding this comment.
I grabbed it without that one piece.
Daniel-KM
force-pushed
the
fix/ongoing
branch
from
df44748 to
19d4fa8
Compare
|
Rebased on 1.3. |
|
Rebased on 1.4. |
|
Added various missing translation and docblocks. |
Daniel-KM
force-pushed
the
fix/ongoing
branch
from
4ecf34f to
2066ce3
Compare
Daniel-KM
force-pushed
the
fix/ongoing
branch
3 times, most recently
from
1645fe5 to
8058456
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
$translate()is a little quicker to use than$this->translate(), but the main advantage is for the theme designers, because it is simpler to write.