Affected Issue(s): Fixes when try to run within Windows OS environment #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves sid-indonesia/it-team#313 What this commit has achieved: 1. Renamed an entry in `.env` from `username` to `user_name` to accomodate usage within Windows OS (there is a default OS env var %username% within Windows OS) 2. Added `python-magic-bin` to the `requirements.txt`, to resolve issue of: ``` ImportError: failed to find libmagic. Check your installation ``` (Possibly only happens in Windows OS, not really sure)
Wambere
reviewed
Aug 23, 2024
Resolves sid-indonesia/it-team#313 What this commit has achieved: 1. Only add `python-magic-bin` as one of the requirements if the `sys_platform` is Windows.
|
@muhammad-levi please also change |
Resolves sid-indonesia/it-team#313 What this commit has achieved: 1. Renamed env var `username` to `user_name` in `pytest.ini`. 2. Corrected the order of default values in the `README.md` of `importer`.
Wambere
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/sid-indonesia/it-team/issues/313
What this commit has achieved:
.envfromusernametouser_nameto accomodate usage within Windows OS (there is a default OS env var %username% within Windows OS)python-magic-binto therequirements.txt, to resolve issue of:(Possibly only happens in Windows OS, not really sure)