Equalize arena slots #1436
Draft
Equalize arena slots #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously arena::my_references served for performance optimization, quota on number of workers was provided by occupy_free_slot</*as_worker*/true>() logic. In the patch arena::my_references is used for following to the reserved_for_masters limit.
Alexandr-Konovalov
force-pushed
the
dev/Alexandr-Konovalov/equalize-arena-slots
branch
from
db0bea2
to
c744fcb
Compare
|
@Alexandr-Konovalov Please, fix the copyright year and spelling. |
Thanks, done. |
| if (!same_arena) { | ||
| index1 = a->occupy_free_slot</*as_worker */false>(*td); | ||
| index1 = a->occupy_free_slot(*td); | ||
| is_worker_slot = false; |
There was a problem hiding this comment.
Why we unset the flag?
I did not get the idea: how we distinguish if external thread occupied the workers slot.
There was a problem hiding this comment.
Good point, here can be a problem place. Logic behind is_worker_slot = false; is that the calling thread got index1 slot as a master, so not consuming from quota of workers slots. Is it the invalid reasoning?
There was a problem hiding this comment.
What if there are more external threads than reserved slots then these external threads will take slots from workers quota.
Am I missing something?
|
Issue: #1281 Build on openSUSE 15.5: CC=gcc-11 CXX=g++-11 cmake -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_CXX_STANDARD=20 -DCMAKE_INTERPROCEDURAL_OPTIMIZATION=ON ../..
cmake --build . --verbose --config Release -j8
ctest --timeout 180 --build-config Release -R test_scheduler_mix --repeat-until-fail 32000 |
|
To reproduce this hangs, a small and random third-party load on the CPU is required. |
Yes. I can't give you access to the computer, but I can run gdb and run the commands you suggested. |
Oh, thank you. Looking at the backtraces for the hang would be very helpful! |
|
OS: Debian 12 Build information: Backtraces: |
13 tasks
|
Any news? |
I able to reproduce your error report locally. Besides this, no news. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously arena::my_references served for performance optimization, quota on number of workers was provided by
occupy_free_slot</*as_worker*/true>()logic. In the patcharena::my_referencesis used for maintenance of thereserved_for_masterslimit.Fixes # - issue number(s) if exists
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@to send notificationsOther information