Skip to content

Move the longest drd tests to Nightly build #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ldorau
Copy link
Contributor

@ldorau ldorau commented May 9, 2025

Description

Move the longest drd tests to Nightly build (in seconds):

1834.73user ./test/test_jemalloc_pool
389.64user  ./test/test_jemalloc_coarse_file
294.00user  ./test/test_scalable_pool
208.11user  ./test/test_ipc_max_opened_limit

and in minutes:

30,57 min ./test/test_jemalloc_pool
 6,49 min ./test/test_jemalloc_coarse_file
 4,90 min ./test/test_scalable_pool
 3,47 min ./test/test_ipc_max_opened_limit

Add the drdshort option to the valgrind script.

It decreases time of the drd test from 48 minutes to less than 7 minutes.

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

@ldorau ldorau force-pushed the Move_the_longest_drd_tests_to_Nightly_build branch from 605408e to c0eada6 Compare May 9, 2025 10:51
@ldorau ldorau marked this pull request as ready for review May 9, 2025 10:57
@ldorau ldorau requested a review from a team as a code owner May 9, 2025 10:57
case $TOOL in
memcheck)
OPTION="--leak-check=full"
;;
drd)
OPTION="--tool=drd"
;;
drdnolong)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the naming be reversed? e.g. drdshort = run tests with exclusions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ldorau
Copy link
Contributor Author

ldorau commented May 9, 2025

It decreases time of the drd test from 48 minutes to less than 7 minutes.

@ldorau ldorau force-pushed the Move_the_longest_drd_tests_to_Nightly_build branch 3 times, most recently from 7d60f11 to 4deba20 Compare May 9, 2025 13:11
Move the longest drd tests to Nightly build.
Add the drdshort option to the valgrind script.

Signed-off-by: Lukasz Dorau <[email protected]>
@ldorau ldorau force-pushed the Move_the_longest_drd_tests_to_Nightly_build branch from 4deba20 to 71fd678 Compare May 9, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants