Skip to content

Move the longest drd tests to Nightly build #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move the longest drd tests to Nightly build #1306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/reusable_valgrind.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
run: ${{github.workspace}}/test/test_valgrind.sh ${{github.workspace}} ${{github.workspace}}/build memcheck

- name: Run tests with 'drd'
run: ${{github.workspace}}/test/test_valgrind.sh ${{github.workspace}} ${{github.workspace}}/build drd
run: ${{github.workspace}}/test/test_valgrind.sh ${{github.workspace}} ${{github.workspace}}/build drdshort

- name: Run tests with 'helgrind'
run: ${{github.workspace}}/test/test_valgrind.sh ${{github.workspace}} ${{github.workspace}}/build helgrind
22 changes: 20 additions & 2 deletions test/test_valgrind.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@ TOOL=$3
TESTS=$4

function print_usage() {
echo "$(basename $0) - run UMF tests and examples under a valgrind tool (memcheck, drd or helgrind)"
echo "Usage: $(basename $0) <workspace_dir> <build_dir> <memcheck|drd|helgrind> [tests_examples]"
echo "$(basename $0) - run UMF tests and examples under a valgrind tool (memcheck, drd, drdshort or helgrind)"
echo " drdshort - same as drd, but the longest lasting tests are excluded"
echo "Usage: $(basename $0) <workspace_dir> <build_dir> <memcheck|drd|drdshort|helgrind> [tests_examples]"
echo "Where:"
echo
echo "tests_examples - (optional) list of tests or examples to be run (paths relative to the <build_dir> build directory)."
Expand Down Expand Up @@ -43,13 +44,20 @@ if [ $(ls -1 ${BUILD_DIR}/test/test_* 2>/dev/null | wc -l) -eq 0 ]; then
exit 1
fi

EXCLUDE_LONGEST_TESTS=0

case $TOOL in
memcheck)
OPTION="--leak-check=full"
;;
drd)
OPTION="--tool=drd"
;;
drdshort)
OPTION="--tool=drd"
TOOL="drd"
EXCLUDE_LONGEST_TESTS=1
;;
helgrind)
OPTION="--tool=helgrind"
;;
Expand Down Expand Up @@ -150,6 +158,16 @@ for test in $TESTS; do
;;
esac

if [ $EXCLUDE_LONGEST_TESTS -eq 1 ]; then
# skip the longest tests
case $test in
./test/test_jemalloc_pool|./test/test_jemalloc_coarse_file|./test/test_scalable_pool|./test/test_ipc_max_opened_limit)
echo "- SKIPPED (VERY LONG TEST)"
continue;
;;
esac
fi

[ "$FILTER" != "" ] && echo -n "($FILTER) "

LAST_TEST_FAILED=0
Expand Down
Loading