[12.0] Fix issues with connector_office_365 and hr.leaves #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the ORM returns False in that case, and you get a crash when concatenating strings and booleans
the validation of the leave creates the calendar event which is immediately exported to Office 365, and this fails if the employee is not authenticated. This fix calls super() with a changed context to prevent the synchronisation of the event to Office 365, and give us the chance to create the task requesting the employee to authenticate to get the proper creation of the event in Office 365
guewen
approved these changes
Jul 10, 2020
and add an error log when access is refused
gurneyalex
force-pushed
the
12.0-fix_connector_office_365
branch
from
add166f
to
90f9eb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The details are in each commit