Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0] Fix issues with connector_office_365 and hr.leaves #83

Open
wants to merge 3 commits into
base: 12.0
Choose a base branch
from
Open

[12.0] Fix issues with connector_office_365 and hr.leaves #83

wants to merge 3 commits into from

Commits on Jul 9, 2020

  1. [FIX] avoid crash if tenant_id is not set 

    the ORM returns False in that case, and you get a crash when concatenating
strings and booleans
    @gurneyalex
    gurneyalex committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    519bfc4 View commit details
    Browse the repository at this point in the history

  2. [FIX] validation of leave if employee is not authenticated 

    the validation of the leave creates the calendar event which is immediately
exported to Office 365, and this fails if the employee is not authenticated.

This fix calls super() with a changed context to prevent the synchronisation of
the event to Office 365, and give us the chance to create the task requesting the
employee to authenticate to get the proper creation of the event in Office 365
    @gurneyalex
    gurneyalex committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    d827554 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2021

  1. [IMP] improve error message 

    and add an error log when access is refused
    @gurneyalex
    gurneyalex committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    90f9eb0 View commit details
    Browse the repository at this point in the history