Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input/#2883): Handle alternate input productions #2902

Merged
merged 29 commits into from
Jan 1, 2021
Merged

fix(input/#2883): Handle alternate input productions #2902

merged 29 commits into from
Jan 1, 2021

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented Dec 30, 2020 •
edited
Loading

Fixes #2883

TODO:

  • Make use of our new keyboard layout module (thanks @zbaylin !)
  • Bring back special-key handling
  • Add test case for Unable to create mappings with colon. #2883
  • Fix scancodes / verify 'AllKeysReleased' behavior for Control+Tab
  • Fix bug with C-C / C-D / C-U being forwarded to Vim
  • Fix newly introduced bug with Control+Shift+P/Cmd+Shift+P

Next steps:

@bryphe bryphe added the WIP label Dec 30, 2020
@bryphe bryphe removed the WIP label Dec 31, 2020
@bryphe bryphe merged commit a55e692 into master Jan 1, 2021
@bryphe bryphe deleted the fix/input/2883/alt-productions branch January 1, 2021 02:09
bryphe added a commit that referenced this pull request Jan 1, 2021
@bryphe
Revert "fix(input/#2883): Handle alternate input productions (#2902)"
a5889dd 
This reverts commit a55e692.
@bryphe bryphe mentioned this pull request Jan 1, 2021
Closed
bryphe added a commit that referenced this pull request Jan 1, 2021
@bryphe
Revert "Revert "fix(input/#2883): Handle alternate input productions (#…
425f2ac 
…2902)""

This reverts commit a5889dd.
This was referenced Jan 1, 2021
Closed
Merged
bryphe added a commit that referenced this pull request Jan 4, 2021
@bryphe
fix(input/#2926): Part 2 - Right arrow key treated as PageUp (#2928)
613c38c 
__Issue:__ Right arrow key is being treated as page-up

__Defect:__ An incorrect conversion snuck in #2902 

__Fix:__ Fix the keycode -> key mapping for right arrow key

Related #2926
@bryphe bryphe mentioned this pull request Jan 5, 2021
Merged
bryphe added a commit that referenced this pull request Jan 6, 2021
@bryphe
fix(osx/#2924): Modifier keys not working with Romanji keyboard (#2938)
d4e21ff 
__Issue:__ On OSX, if the Romanji keyboard is selected, keys with modifiers (`Cmd+P`, etc) would not be processed correctly.

__Defect:__ This was a regression from #2902 - in that change, we rely on querying our `keyboard-layout` library for keymap information. However, we weren't able to get keymap information for Japanese / virtual keyboard layouts.

__Fix:__ Turns out a similar issue was encountered in the `node-native-keymap` library here: microsoft/node-native-keymap@f735d67

Ported over a similar fix for our `keyboard-layout` strategy - first, try `TISCopyCurrentKeyboardInputSource`, and if that returns `NULL`, try `TISCopyCurrentKeyboardLayoutInputSource`.

Fixes #2924
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to create mappings with colon.
1 participant
@bryphe