Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace tail package with maintained one to fix go get errors #667

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

ryancurrah
Copy link
Contributor

The tail package depends on an incorrect version of fsnotify which causes downloads of the ginkgo module to fail with...

go: finding module for package github.com/go-fsnotify/fsnotify
go.acme.com/utils tested by
        go.acme.com/utils.test imports
        github.com/onsi/ginkgo imports
        github.com/onsi/ginkgo/internal/remote imports
        github.com/hpcloud/tail imports
        github.com/hpcloud/tail/watch imports
        gopkg.in/fsnotify.v1 tested by
        gopkg.in/fsnotify.v1.test imports
        github.com/go-fsnotify/fsnotify: module github.com/go-fsnotify/fsnotify@latest found (v0.0.0-20180321022601-755488143dae), but does not contain package github.com/go-fsnotify/fsnotify: exit status 1

For more info see: hpcloud/tail#168

The author of tail has forked it from HP and is now maintaining it at https://github.com/nxadm/tail. HP is not going to make any updates to the package so it is recommended to replace the module with the maintained one.

@blgm blgm merged commit 4ba33d4 into onsi:master Apr 27, 2020
@blgm
Copy link
Collaborator

blgm commented Apr 27, 2020

Thank you @ryancurrah!

@110y
Copy link

110y commented May 16, 2020

@blgm

Can you release new version of ginkgo so that we can use this changes 🙏
(Though I know we can use @master, however I'd like to specify tag to my dependencies.)

@blgm
Copy link
Collaborator

blgm commented May 16, 2020

Thanks for the reminder @110y, new tag here: https://github.com/onsi/ginkgo/releases/tag/v1.12.1

@110y
Copy link

110y commented May 18, 2020

Thank you so much 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants