-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature | Support multi-lingual: UI Internationalization #228
Conversation
…-lirmm/bioportal_web_ui into feature/support-multi-lingual
…n/feature/support-multi-lingual"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haddadzineddine, when using your branch
because you updated the configuration variable $HOME_PAGE_LOGOS
, like so
$HOME_PAGE_LOGOS = [
{
title: {
en: 'Supported by',
fr: 'Soutenu par',
},
....
But as we discussed, we want all internationalization to be done in the local files not in the configuration files which need to be generic and no language-related.
e4a9b5c
to
17c589c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work;
Two remarks:
- It does not work for the browse page, will be fixed with this Feature: Update browse page design #217
- The summary page is not fully localized, will be fixed when we update it to the new UI
…ingual Feature | Support multi-lingual: UI Internationalization
Context
See : agroportal/project-management#309
Changes
Translated Pages
Documentation