Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added compose example for MultimodalQnA deployment on AMD ROCm systems #1233

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

artem-astafev
Copy link
Contributor

Description

Changes for MultimodalQnA example deployment to AMD ROCm systems.

Type of change

  • Added compose example for MultimodalQnA deployment on AMD ROCm systems.
  • Added Readme file for MultimodalQnA compose deployment example on AMD ROCm systems.
  • Added CI tests for MultimodalQnA compose deployment example on AMD ROCm systems.

Tests

For manual test s go to GenAIExamples/MultimodalQnA/tests dir and run test_compose_on_rocm.sh script (./test_compose_on_rocm.sh)

@artem-astafev artem-astafev force-pushed the feature/MultimodalQnA-add-compos-example-for-amd-rocm branch from 15ea852 to 95f9b07 Compare December 6, 2024 08:40
pre-commit-ci bot and others added 13 commits December 6, 2024 08:42
Signed-off-by: Artem Astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
Copy link
Collaborator

@letonghan letonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @artem-astafev , thanks for your contribution.
Please check the comment here and refine the set_env part in your readme.

```

```bash
export no_proxy=${your_no_proxy}
Copy link
Collaborator

@letonghan letonghan Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you already have the 'set_env.sh' script, please use that script here and delete the redundant env settings: 'source ./set_env.sh'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @letonghan,

Done, Environment set part description is changed to run set_env.sh for setting up environment variables.

Signed-off-by: Artem Astafev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants