feat: export tagged library as csv (TEMP)

[rpenido]

No description provided.

[pomegranited]

Hi @rpenido ! This is working well, but I've suggested a few changes here.

Thank you for splitting this code into an internal PR, it really helped me see what was changed for libraries :)

[pomegranited]

Up here we can decide which method to use when fetching child blocks, so we don't have to do the type checks in the loop below:

Suggested change

	if isinstance(content_key, CourseKey):
	tagged_content, children = get_course_tagged_object_and_children(
	content_key, object_tag_cache
	)
	elif isinstance(content_key, LibraryLocatorV2):
	tagged_content, children = get_library_tagged_object_and_children(
	content_key, object_tag_cache
	)
	if isinstance(content_key, CourseKey):
	tagged_content, children = get_course_tagged_object_and_children(
	content_key, object_tag_cache
	)
	get_tagged_children = get_xblock_tagged_object_and_children
	elif isinstance(content_key, LibraryLocatorV2):
	tagged_content, children = get_library_tagged_object_and_children(
	content_key, object_tag_cache
	)
	get_tagged_children = get_library_block_tagged_object

But you'll need to remove the store parameter from get_xblock_tagged_object_and_children and just call this again (it's ok to do this, the modulestore is globally cached):

    store = modulestore()

[pomegranited]

Now we can use the get_tagged_children variable set in my suggestion above:

Suggested change

	if isinstance(child, UsageKey):
	tagged_child, child_children = get_xblock_tagged_object_and_children(
	child, object_tag_cache, store
	)
	elif isinstance(child, LibraryXBlockMetadata):
	tagged_child, child_children = get_library_block_tagged_object(
	child, object_tag_cache
	)
	tagged_block.children.append(tagged_child)
	else:
	raise NotImplementedError(f"Invalid child: {type(child)} -> {child}")
	tagged_child, child_children = get_tagged_children(child, object_tag_cache)

[rpenido]

Done: 610c01a

At first, I thought we would still need a type guard before calling the function, but the types were inferred just right.

The code is way cleaner now! Thank you!

Edit: My lsp didn't found any issues but our static type checker didn't like it. It uses the first variable assignment to define the type:

openedx/core/djangoapps/content_tagging/rest_api/v1/objecttag_export_helpers.py:150: error: Incompatible types in assignment (expression has type "Callable[[LibraryXBlockMetadata, Dict[str, Dict[int, List[Any]]]], Tuple[TaggedContent, None]]", variable has type "Callable[[UsageKey, Dict[str, Dict[int, List[Any]]]], Tuple[TaggedContent, List[Any]]]")  [assignment]

I did an explicit typing here: 4012481
Not pretty, but I think it is better than disable the type checking. Do you know a better way to do this?

[pomegranited]

@rpenido sorry, I don't know a better way to do this.. but I agree, having an ugly type definition is better than disabling type checking.

[rpenido]

Closed in favor of openedx#34246