fix: scope of webhook configurations #3676
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: plavy <[email protected]>
JaydipGabani
requested changes
Nov 5, 2024
cmd/build/helmify/replacements.go
Outdated
| @@ -173,6 +173,7 @@ var replacements = map[string]string{ | |||
| - services/proxy | |||
| - nodes/proxy | |||
| - services/status | |||
| scope: 'Namespaced' | |||
There was a problem hiding this comment.
Let's not modify existing behavior. Can you use helm to conditionally set the field separetly?
There was a problem hiding this comment.
I am reading it from the values now, what do you think?
Signed-off-by: plavy <[email protected]>
Signed-off-by: tin.plavec <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3676 +/- ##
==========================================
- Coverage 54.49% 47.54% -6.96%
==========================================
Files 134 236 +102
Lines 12329 19909 +7580
==========================================
+ Hits 6719 9466 +2747
- Misses 5116 9551 +4435
- Partials 494 892 +398
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JaydipGabani
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As described in the issue, scope of the webhooks is not set, defaulting to unrestricted scope.
namespaceSelectoris therefore not fully enforced.Which issue(s) this PR fixes:
Fixes #3675