Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scope of webhook configurations #3676

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+8 −0
Open

fix: scope of webhook configurations #3676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
54e2593
set webhook scope to Namespaced
plavy Oct 30, 2024
66d8be9
read webhook scope from values
plavy Nov 6, 2024
c237bd5
rm unwanted file
Nov 6, 2024
6d4cd74
Merge branch 'master' into fix/webhooks
JaydipGabani Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cmd/build/helmify/replacements.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ var replacements = map[string]string{
- services/proxy
- nodes/proxy
- services/status
scope: '{{ .Values.mutatingWebhookScope }}'
{{- end }}`,

"HELMSUBST_MUTATING_WEBHOOK_CLIENT_CONFIG: \"\"": `{{- if .Values.mutatingWebhookURL }}
Expand Down Expand Up @@ -264,6 +265,7 @@ var replacements = map[string]string{
- 'nodes/proxy'
# For constraints that mitigate CVE-2020-8554
- 'services/status'
scope: '{{ .Values.validatingWebhookScope }}'
{{- end }}`,

"HELMSUBST_MUTATING_WEBHOOK_MATCH_CONDITIONS": `{{ toYaml .Values.mutatingWebhookMatchConditions | nindent 4 }}`,
Expand Down
2 changes: 2 additions & 0 deletions cmd/build/helmify/static/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ validatingWebhookMatchConditions: []
validatingWebhookCheckIgnoreFailurePolicy: Fail
validatingWebhookCustomRules: {}
validatingWebhookURL: null
validatingWebhookScope: '*'
enableDeleteOperations: false
enableConnectOperations: false
enableExternalData: true
Expand All @@ -34,6 +35,7 @@ mutatingWebhookMatchConditions: []
mutatingWebhookTimeoutSeconds: 1
mutatingWebhookCustomRules: {}
mutatingWebhookURL: null
mutatingWebhookScope: '*'
mutationAnnotations: false
auditChunkSize: 500
logLevel: INFO
Expand Down
1 change: 1 addition & 0 deletions ...per/templates/gatekeeper-mutating-webhook-configuration-mutatingwebhookconfiguration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ webhooks:
- services/proxy
- nodes/proxy
- services/status
scope: '{{ .Values.mutatingWebhookScope }}'
{{- end }}
sideEffects: None
timeoutSeconds: {{ .Values.mutatingWebhookTimeoutSeconds }}
Expand Down
1 change: 1 addition & 0 deletions ...templates/gatekeeper-validating-webhook-configuration-validatingwebhookconfiguration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ webhooks:
- 'nodes/proxy'
# For constraints that mitigate CVE-2020-8554
- 'services/status'
scope: '{{ .Values.validatingWebhookScope }}'
{{- end }}
sideEffects: None
timeoutSeconds: {{ .Values.validatingWebhookTimeoutSeconds }}
Expand Down
2 changes: 2 additions & 0 deletions manifest_staging/charts/gatekeeper/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ validatingWebhookMatchConditions: []
validatingWebhookCheckIgnoreFailurePolicy: Fail
validatingWebhookCustomRules: {}
validatingWebhookURL: null
validatingWebhookScope: '*'
enableDeleteOperations: false
enableConnectOperations: false
enableExternalData: true
Expand All @@ -34,6 +35,7 @@ mutatingWebhookMatchConditions: []
mutatingWebhookTimeoutSeconds: 1
mutatingWebhookCustomRules: {}
mutatingWebhookURL: null
mutatingWebhookScope: '*'
mutationAnnotations: false
auditChunkSize: 500
logLevel: INFO
Expand Down
Loading