Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding scale for icons #196

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Adding scale for icons #196

merged 2 commits into from
Oct 30, 2023

Conversation

aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented Oct 30, 2023 •
edited
Loading

New feature implementation

Implemented feature

  • Adding scale to each icon mentioned, this will help render the icons more realistically on the dashboard
  • Fixed a naming typo for hotel robots

image

@aaronchongth
Adding scale for icons
bb7fbfa 
Signed-off-by: Aaron Chong <[email protected]>
@aaronchongth aaronchongth mentioned this pull request Oct 30, 2023
Merged
5 tasks
@aaronchongth
Correct scales
92d3614 
Signed-off-by: Aaron Chong <[email protected]>
youliangtan
youliangtan approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@youliangtan youliangtan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scale <3!

@aaronchongth aaronchongth merged commit fc2c137 into main Oct 30, 2023
3 checks passed
@aaronchongth aaronchongth deleted the feature/dashboard-icon-scale branch October 30, 2023 22:18
proffessorx added a commit to proffessorx/rmf_demos that referenced this pull request Nov 2, 2023
@proffessorx
Merge pull request #2 from open-rmf/main
82bb9bf 
 latest changes: Adding scale for icons (open-rmf#196)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youliangtan youliangtan youliangtan approved these changes

@Yadunund Yadunund Yadunund approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaronchongth @Yadunund @youliangtan