Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use site ID to ensure unique file names #219

Merged
merged 4 commits into from
Jun 14, 2024
Merged

Use site ID to ensure unique file names #219

merged 4 commits into from
Jun 14, 2024

Conversation

mxgrey
Copy link
Collaborator

@mxgrey mxgrey commented Jun 3, 2024

This uses Site ID values in file names for the following benefits:

  1. The filenames will be the same even as the names of entities change
  2. The correct filenames will be produced even if duplicate names exist among different models

@mxgrey mxgrey mentioned this pull request Jun 3, 2024
Merged
mxgrey and others added 2 commits June 3, 2024 16:14
@luca-della-vedova
Copy link
Member

This breaks the level transparency plugin since it uses model names, looking into it

@luca-della-vedova
Copy link
Member

Regression should be fixed by 2872ab8, merging

@luca-della-vedova luca-della-vedova merged commit bb43fcb into luca/headless_sdf_export_poc Jun 14, 2024
5 checks passed
@luca-della-vedova luca-della-vedova deleted the grey/sdf_site_id branch June 14, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luca-della-vedova luca-della-vedova luca-della-vedova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxgrey @luca-della-vedova