Skip to content

Commit

Permalink
Merge pull request #2 from open-rpc/BelfordZ/fix-npm-install-error
Browse files Browse the repository at this point in the history
Fix npm install error by removing monaco-vim and updating dependencies
  • Loading branch information
BelfordZ authored Nov 28, 2024
2 parents 6869ccf + 0171460 commit b693e15
Show file tree
Hide file tree
Showing 19 changed files with 32 additions and 109 deletions.
2 changes: 1 addition & 1 deletion .node-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
14.17.5
18.20.5
2 changes: 1 addition & 1 deletion .nodenv
Original file line number Diff line number Diff line change
@@ -1 +1 @@
14.17.5
18.20.5
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
18.20.5
14 changes: 13 additions & 1 deletion README.md
100755 → 100644
Original file line number Diff line number Diff line change
@@ -1 +1,13 @@
WIP WIP
# Using nvm

This project uses `nvm` to manage Node.js versions. To use the correct Node.js version, run the following command in the root of the repository and in each package directory:

```sh
nvm use
```

If you do not have the required Node.js version installed, you can install it using the following command:

```sh
nvm install
```
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@
"turbo": "^1.0.0"
},
"engines": {
"node": ">=14.0.0"
"node": ">=18.20.5"
}
}
1 change: 1 addition & 0 deletions packages/docs-react/.nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
18.20.5
3 changes: 2 additions & 1 deletion packages/docs-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@
"json-schema-ref-parser": "^7.0.1",
"ts-jest": "^24.0.0",
"tslint": "^5.14.0",
"typescript": "^3.9.7"
"typescript": "^3.9.7",
"react-scripts": "3.4.4"
},
"files": [
"build"
Expand Down
1 change: 1 addition & 0 deletions packages/inspector/.nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
18.20.5
7 changes: 3 additions & 4 deletions packages/inspector/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,15 @@
"author": "",
"license": "Apache-2.0",
"devDependencies": {
"@rescripts/cli": "0.0.13",
"@rescripts/utilities": "0.0.6",
"@rescripts/cli": "latest",
"@rescripts/utilities": "0.0.7",
"@types/jest": "^24.0.13",
"@types/qs": "^6.5.3",
"@types/react-dom": "^16.8.4",
"@types/use-persisted-state": "^0.3.0",
"jest": "24.9.0",
"monaco-editor-webpack-plugin": "^1.7.0",
"react-scripts": "^3.3.0",
"react-scripts": "3.4.4",
"ts-jest": "^24.0.2",
"tslint": "^5.17.0",
"typescript": "^3.7.3"
Expand Down Expand Up @@ -61,7 +61,6 @@
"@rehooks/window-size": "^1.0.2",
"acorn-dynamic-import": "^4.0.0",
"monaco-editor": "^0.18.1",
"monaco-vim": "0.0.14",
"qs": "^6.8.0",
"react": "^16.12.0",
"react-dom": "^16.12.0",
Expand Down
2 changes: 0 additions & 2 deletions packages/inspector/src/containers/JSONRPCRequestEditor.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import { MethodObject, OpenrpcDocument } from "@open-rpc/meta-schema";
import useWindowSize from "@rehooks/window-size";
import { addDiagnostics } from "@etclabscore/monaco-add-json-schema-diagnostics";
import openrpcDocumentToJSONRPCSchema from "../helpers/openrpcDocumentToJSONRPCSchema";
import useMonacoVimMode from "../hooks/useMonacoVimMode";

interface IProps {
onChange?: (newValue: any) => void;
Expand All @@ -16,7 +15,6 @@ interface IProps {

const JSONRPCRequestEditor: React.FC<IProps> = (props) => {
const [editor, setEditor] = useState();
useMonacoVimMode(editor);
const windowSize = useWindowSize();
useEffect(() => {
if (editor) {
Expand Down
2 changes: 0 additions & 2 deletions packages/inspector/src/containers/OptionsEditor.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import * as monaco from "monaco-editor";
import { JSONSchema, MethodObject } from "@open-rpc/meta-schema";
import useWindowSize from "@rehooks/window-size";
import { addDiagnostics } from "@etclabscore/monaco-add-json-schema-diagnostics";
import useMonacoVimMode from "../hooks/useMonacoVimMode";

interface IProps {
onChange?: (newValue: any) => void;
Expand All @@ -15,7 +14,6 @@ interface IProps {

const OptionsEditor: React.FC<IProps> = (props) => {
const [editor, setEditor] = useState();
useMonacoVimMode(editor);
const windowSize = useWindowSize();
useEffect(() => {
if (editor) {
Expand Down
40 changes: 0 additions & 40 deletions packages/inspector/src/hooks/useMonacoVimMode.ts

This file was deleted.

1 change: 1 addition & 0 deletions packages/logs-react/.nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
18.20.5
6 changes: 3 additions & 3 deletions packages/logs-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
],
"publishConfig": {
"access": "public"
},
],
"scripts": {
"start": "rescripts start",
"build": "rescripts build",
Expand All @@ -20,12 +20,12 @@
"author": "",
"license": "Apache-2.0",
"devDependencies": {
"@rescripts/cli": "0.0.14",
"@rescripts/cli": "latest",
"@rescripts/utilities": "0.0.7",
"@types/jest": "^24.0.13",
"@types/react-dom": "16.9.4",
"monaco-editor-webpack-plugin": "1.7.0",
"react-scripts": "3.4.1",
"react-scripts": "3.4.4",
"ts-jest": "^24.0.2",
"tslint": "^5.17.0",
"typescript": "^3.7.3"
Expand Down
1 change: 1 addition & 0 deletions packages/playground/.nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
18.20.5
7 changes: 0 additions & 7 deletions packages/playground/__mocks__/monaco-vim.js

This file was deleted.

7 changes: 3 additions & 4 deletions packages/playground/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
"jsonschema": "^1.2.4",
"lodash": "^4.17.21",
"monaco-editor": "^0.18.1",
"monaco-vim": "0.0.14",
"open": "^6.4.0",
"qs": "^6.11.0",
"react": "^16.12.0",
Expand Down Expand Up @@ -61,8 +60,8 @@
"not op_mini all"
],
"devDependencies": {
"@rescripts/cli": "0.0.13",
"@rescripts/utilities": "0.0.6",
"@rescripts/cli": "latest",
"@rescripts/utilities": "0.0.7",
"@types/classnames": "^2.2.9",
"@types/css-mediaquery": "^0.1.0",
"@types/jest": "^24.0.23",
Expand All @@ -73,7 +72,7 @@
"@types/react-dom": "^16.8.4",
"css-mediaquery": "^0.1.2",
"monaco-editor-webpack-plugin": "^1.7.0",
"react-scripts": "^3.4.3",
"react-scripts": "3.4.4",
"tslint": "^6.1.3",
"typescript": "^3.7.3"
},
Expand Down
2 changes: 0 additions & 2 deletions packages/playground/src/App.tsx
100755 → 100644
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import searchBarStore from "./stores/searchBarStore";
import examples from "./examplesList";
import OpenRPCEditor from "./OpenRPCEditor";
import useMonacoReplaceMetaSchema from "./hooks/useMonacoReplaceMetaSchema";
import useMonacoVimMode from "./hooks/useMonacoVimMode";
import { IExample } from "./ExampleDocumentsDropdown/ExampleDocumentsDropdown";
import Inspector from "@open-rpc/inspector";
import useInspectorActionStore from "./stores/inspectorActionStore";
Expand Down Expand Up @@ -54,7 +53,6 @@ const App: React.FC = () => {
};
const [inspectorContents] = useInspectorActionStore();
useMonacoReplaceMetaSchema(editor);
useMonacoVimMode(editor);

const handleEditorDidMount = (__: any, ed: any) => {
setEditor(ed);
Expand Down
40 changes: 0 additions & 40 deletions packages/playground/src/hooks/useMonacoVimMode.tsx

This file was deleted.

0 comments on commit b693e15

Please sign in to comment.