Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Add .NET 8 for w3c-trace-context-integration-test in CI #5799

Closed
xiang17 opened this issue Aug 21, 2024 · 1 comment
Closed
Labels
enhancement New feature or request

Comments

@xiang17
Copy link
Contributor

xiang17 commented Aug 21, 2024

Package

None

Is your feature request related to a problem?

The W3C Trace Context Integration Test in Docker doesn't have .NET 8 target.

What is the expected behavior?

Need to add .NET 8 as target.

Which alternative solutions or features have you considered?

None

Additional context

I added .NET 8 and got the following error.

#19 16.47 Processing triggers for libc-bin (2.36-9+deb12u7) ...
#19 16.77 error: externally-managed-environment
#19 16.77 
#19 16.77 × This environment is externally managed
#19 16.77 ╰─> To install Python packages system-wide, try apt install
#19 16.77     python3-xyz, where xyz is the package you are trying to
#19 16.77     install.
#19 16.77     
#19 16.77     If you wish to install a non-Debian-packaged Python package,
#19 16.77     create a virtual environment using python3 -m venv path/to/venv.
#19 16.77     Then use path/to/venv/bin/python and path/to/venv/bin/pip. Make
#19 16.77     sure you have python3-full installed.
#19 16.77     
#19 16.77     If you wish to install a non-Debian packaged Python application,
#19 16.77     it may be easiest to use pipx install xyz, which will manage a
#19 16.77     virtual environment for you. Make sure you have pipx installed.
#19 16.77     
#19 16.77     See /usr/share/doc/python3.11/README.venv for more information.
#19 16.77 

Can reproduce by locally running the same command: docker compose --file=test/OpenTelemetry.Instrumentation.W3cTraceContext.Tests/docker-compose.yml --file=build/docker-compose.net8.0.yml --project-directory=. up --exit-code-from=tests --build.

After fixing the Dockerfile with venv (https://stackoverflow.com/questions/75602063/pip-install-r-requirements-txt-is-failing-this-environment-is-externally-mana), the tests still fails because the Dotnet runtime invoking Python command doesn't have venv context.

@xiang17 xiang17 added enhancement New feature or request needs-triage New issues which have not been classified or triaged by a community member labels Aug 21, 2024
@vishweshbankwar vishweshbankwar removed the needs-triage New issues which have not been classified or triaged by a community member label Aug 22, 2024
@vishweshbankwar vishweshbankwar added this to the Future milestone Aug 26, 2024
@xiang17
Copy link
Contributor Author

xiang17 commented Sep 6, 2024

This is finished with the last PR.

@xiang17 xiang17 closed this as completed Sep 6, 2024
@CodeBlanch CodeBlanch removed this from the Future milestone Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants