[repo] Add .NET 8 target for W3C Trace Context Integration Test in CI #5800
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5800 +/- ##
==========================================
+ Coverage 83.38% 86.34% +2.95%
==========================================
Files 297 257 -40
Lines 12531 11150 -1381
==========================================
- Hits 10449 9627 -822
+ Misses 2082 1523 -559
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -88,6 +88,10 @@ public void W3CTraceContextTestSuiteAsync(string value) | |||
| { | |||
| Assert.StartsWith("FAILED (failures=3)", lastLine); | |||
| } | |||
| else if (AspNetCoreHostingVersion.Major == 8) | |||
| { | |||
| Assert.StartsWith("FAILED (failures=40)", lastLine); | |||
There was a problem hiding this comment.
@xiang17 - Could you further investigate to check what is the difference between net8.0 and other versions. Thats lot of failures.
There was a problem hiding this comment.
It might not be trivial to fix. Can we complete this PR first? The issue can be kept open to track the issue.
There was a problem hiding this comment.
@xiang17, I do not think that Vishwesh is asking for the fix in the scope of the PR, but it will be great to find what is the root cause.
There was a problem hiding this comment.
Yes, just looking for the root cause.
There was a problem hiding this comment.
I've figured it out. Apparently .NET 8 on Linux changed the default port for ASP.NET Core (but not changed on Windows, which explained why local Windows works but not in Docker).
…inux changed. (But it's not changed on Windows, which explains why the test would pass on Windows if you download the W3C tests locally and change the path at line `RunCommand("python", "trace-context/test/test.py http://localhost:5000/")`.)
CodeBlanch
changed the title
Towards #5799
Design discussion issue #
Changes
--break-system-packages. (mcr.microsoft.com/dotnet/sdk:net6.0image uses Python 3.9, which doesn't have--break-system-packagesoption, thus adding an alternative to run without this option if it fails.)The W3C integration test on .NET 8 has 40 failing test cases, which I asserted with
Assert.StartsWith("FAILED (failures=40)", lastLine);in this PR.Merge requirement checklist
[ ] Unit tests added/updated[ ] AppropriateCHANGELOG.mdfiles updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)