Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release instrumentation packages 1.7.1/1.7.0-beta.1 #5322

Merged
merged 7 commits into from
Feb 10, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Feb 7, 2024

Changes

Request release for all instrumentation packages. It is especially needed for AspNetCore for AutoInstrumentation due to #5252.
Changes in other packages are also worth to release. The only package with only minor fix is HTTP.

Before merge please check if csproj files for SqlClient and GrpcNetClient shouldn't be updated. In these files there is no definition of MinVerTagPrefix.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@Kielek Kielek requested a review from a team February 7, 2024 05:48
@cijothomas
Copy link
Member

I think version is now aligned with the core api/sdk/exporter packages now.. so do a combined release?

@Kielek
Copy link
Contributor Author

Kielek commented Feb 7, 2024

I think version is now aligned with the core api/sdk/exporter packages now.. so do a combined release?

SqlClient and Grpc was not released with 1.7.0 version. If we speaking about Http and AspNetCore package, the releasing process is currently designed to have it separated from SDK/API.

If we consider changes described in https://github.com/open-telemetry/opentelemetry-dotnet/blob/752778270def63bc710f286856cc9ffe48e7bf39/src/OpenTelemetry/CHANGELOG.md#unreleased - it should not be released as 1.7.1 (sem conv). It brings new functionalities, so natural candidate is 1.8.0. I am not against this, but I am not sure if it is worth to do. Possibility to make semi-independent release seems to be reasonable (sync only major + minor version).

## 1.7.1

Released 2024-Feb-09

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has no mention of #5252

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm mistaken, there's really nothing of note in #5252 that is user facing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the CHANGELOGs, we have previously mentioned stuff that is not user facing but is a significant enough change. From this PR description, it looks like #5252 is the major driver for the new release. I think that it would be useful information for us or the instrumentation folks to look at in the CHANGELOG.

Copy link
Contributor

@utpilla utpilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about updating the CHANGELOG.

@alanwest
Copy link
Member

@utpilla merging, but will follow up on #5322 (comment) if you think there's something we should communicate.

@alanwest alanwest merged commit a2f85dc into open-telemetry:main Feb 10, 2024
17 checks passed
@Kielek Kielek deleted the release-instrumentations branch February 10, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants