Prepare release 0.104.0 #3119

frzifus · 2024-07-10T09:08:03Z

Description:

Link to tracking Issue(s):

Resolves: Release the operator v0.104.0 #3091

Testing:

Documentation:

pavolloffay · 2024-07-10T09:25:20Z

e2e test failed

pavolloffay · 2024-07-10T09:27:52Z

CHANGELOG.md

+
+### Components
+
+* [OpenTelemetry Collector - v0.104.0](https://github.com/open-telemetry/opentelemetry-collector/releases/tag/v0.104.0)


https://github.com/open-telemetry/opentelemetry-collector/releases/tag/v0.104.0

otlpreceiver: Switch to localhost as the default for all endpoints. (open-telemetry/opentelemetry-collector#8510)

We should at least change docs and think about handling this via upgrade or when we generate config map for the collector.

What would you recommend? In case its not specified we switch it explicitly to 0.0.0.0 or set the $POD_IP?

I'd say 0.0.0.0, as this was the default up until now.

CHANGELOG.md

swiatekm

LGTM

frzifus · 2024-07-11T13:27:05Z

Some e2e tests still fail, I will check this in a bit.

https://github.com/open-telemetry/opentelemetry-operator/actions/runs/9892045170/job/27323796957#step:8:929

pavolloffay

it would be great to resolve https://issues.redhat.com/browse/TRACING-4458 before the merge.

pavolloffay · 2024-07-11T14:10:34Z

pkg/collector/upgrade/v0_104_0.go

+				if g.Object == nil {
+					g.Object = make(map[string]interface{})
+				}
+				g.Object["endpoint"] = "0.0.0.0:4317"


This is handling the upgrade, but can you please change examples and readmes to ensure newly crated CRs define endpoint correctly?

https://github.com/open-telemetry/opentelemetry-operator
https://github.com/open-telemetry/opentelemetry-operator/tree/main/config/samples

We could also think about implementing some validation/defaulting for it.

We could also think about implementing some validation/defaulting for it.

Is it a behaviour we want to keep in the long run? If so, I would recommend to set the pod IP instead.

frzifus · 2024-07-11T14:20:08Z

it would be great to resolve https://issues.redhat.com/browse/TRACING-4458 before the merge.

y, I try to reproduce it already.

CHANGELOG.md

jaronoff97 · 2024-07-12T15:27:53Z

apis/v1beta1/collector_webhook.go

+// TAUnifiyEnvVarExpansion enables confmap.unifyEnvVarExpansion featuregate on collector instances associated to TA..
+// NOTE: We need this for now until 0.105.0 is out with this fix:
+// https://github.com/open-telemetry/opentelemetry-collector/commit/637b1f42fcb7cbb7ef8a50dcf41d0a089623a8b7
+func TAUnifiyEnvVarExpansion(otelcol *OpenTelemetryCollector) {


i think we can also be clever about this and only add it if in the config we find a $$1 instance, but this is fine otherwise...

frzifus · 2024-07-13T14:36:16Z

I am working on #3124

frzifus · 2024-07-15T05:47:16Z

Seems we still have another issue:
https://issues.redhat.com/browse/TRACING-4469

pavolloffay · 2024-07-15T07:55:18Z

I booked it here #3133

pavolloffay

https://github.com/open-telemetry/opentelemetry-operator/tree/main/config/samples should be updated as well to include the host if it is mandatory.

pavolloffay · 2024-07-15T07:59:04Z

apis/v1beta1/collector_webhook.go

@@ -449,3 +453,26 @@ func SetupCollectorWebhook(mgr ctrl.Manager, cfg config.Config, reviewer *rbac.R
 		WithDefaulter(cvw).
 		Complete()
 }
+
+// TAUnifiyEnvVarExpansion enables confmap.unifyEnvVarExpansion featuregate on collector instances associated to TA..
+// NOTE: We need this for now until 0.105.0 is out with this fix:


Could you please book a ticket to remove this and add a link to it here?

pavolloffay · 2024-07-17T06:34:55Z

Is that something we want to do? I thought its important to not break existing setups and change it to 0.0.0.0 or $POD_IP afterwards.

I would prefer if this is done as part of this release, but it depends on the complexity of the PR

jaronoff97 · 2024-07-17T00:54:48Z

apis/v1beta1/collector_webhook.go

@@ -79,6 +79,14 @@ func (c CollectorWebhook) Default(_ context.Context, obj runtime.Object) error {
 		otelcol.Spec.TargetAllocator.Replicas = &one
 	}

+	if otelcol.Spec.TargetAllocator.Enabled {
+		TAUnifiyEnvVarExpansion(otelcol)


Suggested change

TAUnifiyEnvVarExpansion(otelcol)

TAUnifyEnvVarExpansion(otelcol)

jaronoff97 · 2024-07-17T00:56:03Z

apis/v1beta1/collector_webhook.go

@@ -79,6 +79,14 @@ func (c CollectorWebhook) Default(_ context.Context, obj runtime.Object) error {
 		otelcol.Spec.TargetAllocator.Replicas = &one
 	}

+	if otelcol.Spec.TargetAllocator.Enabled {


we want to run this for anything with prometheus, not just TA

So instead we would check if any prometheus receiver has been configured?

jaronoff97 · 2024-07-17T00:57:27Z

apis/v1beta1/collector_webhook.go

+
+// DefaultOTLPAddress binds configured otlp receivers to 0.0.0.0 if nothing else
+// is explicitly defined.
+func DefaultOTLPAddress(otelcol *OpenTelemetryCollector) error {


i think we should just disable -component.UseLocalHostAsDefaultHost instead of this

But in the long run we have to change this anyway, right?

yes, but i think it's a bit cleaner to just use the flag given that's the approach for the other breaking change

FTR: we discussed on slack to enable the fg for now and do the PR to bind listeners to 0.0.0.0 or $POD_IP in an extra PR.

cc @jaronoff97 @pavolloffay

pkg/collector/upgrade/v0_104_0.go

jaronoff97 · 2024-07-17T00:59:57Z

pkg/collector/upgrade/versions.go

+		{
+			Version:        *semver.MustParse("0.104.0"),
+			upgradeV1beta1: upgrade0_104_0_TA,
+		},
+		{
+			Version:        *semver.MustParse("0.104.0"),
+			upgradeV1beta1: upgrade0_104_0,
+		},


does it matter if there are two entries for the same version?

Thats not an issue. :)

Signed-off-by: Benedikt Bongartz <[email protected]>

Signed-off-by: Benedikt Bongartz <[email protected]> fix: config structure Signed-off-by: Benedikt Bongartz <[email protected]>

Signed-off-by: Benedikt Bongartz <[email protected]>

CHANGELOG.md

frzifus added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 10, 2024

frzifus marked this pull request as ready for review July 10, 2024 09:09

frzifus requested a review from a team as a code owner July 10, 2024 09:09

frzifus force-pushed the prepare-0.104.0 branch from c9d3e80 to 68ed76d Compare July 10, 2024 09:10

pavolloffay reviewed Jul 10, 2024

View reviewed changes

frzifus force-pushed the prepare-0.104.0 branch 2 times, most recently from d7f4215 to a4b6da4 Compare July 11, 2024 13:08

swiatekm approved these changes Jul 11, 2024

View reviewed changes

pavolloffay requested changes Jul 11, 2024

View reviewed changes

pavolloffay reviewed Jul 12, 2024

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

frzifus force-pushed the prepare-0.104.0 branch 2 times, most recently from 1158f14 to fdf0f4c Compare July 12, 2024 15:15

jaronoff97 reviewed Jul 12, 2024

View reviewed changes

frzifus force-pushed the prepare-0.104.0 branch 6 times, most recently from 01f97ef to d0d4f39 Compare July 13, 2024 12:44

frzifus force-pushed the prepare-0.104.0 branch from d0d4f39 to 4877ece Compare July 13, 2024 20:22

frzifus requested review from jaronoff97 and pavolloffay July 13, 2024 20:22

frzifus mentioned this pull request Jul 14, 2024

Use 0.0.0.0 as otlp receiver default address #3126

Open

15 tasks

pavolloffay reviewed Jul 15, 2024

View reviewed changes

pavolloffay approved these changes Jul 17, 2024

View reviewed changes

jaronoff97 reviewed Jul 17, 2024

View reviewed changes

frzifus added 6 commits July 17, 2024 16:56

Prepare release 0.104.0

7377710

Signed-off-by: Benedikt Bongartz <[email protected]>

adapt to breaking changes

307cb26

Signed-off-by: Benedikt Bongartz <[email protected]>

update changelog

1d34a6c

Signed-off-by: Benedikt Bongartz <[email protected]>

otlpreceiver: bind to 0.0.0.0 by default

84cec02

Signed-off-by: Benedikt Bongartz <[email protected]> fix: config structure Signed-off-by: Benedikt Bongartz <[email protected]>

rename

a186bd1

Signed-off-by: Benedikt Bongartz <[email protected]>

disable unifyEnvVarExpansion if prometheus rec is configured

1daff44

Signed-off-by: Benedikt Bongartz <[email protected]>

frzifus force-pushed the prepare-0.104.0 branch 8 times, most recently from 53f50d2 to 4c270c4 Compare July 17, 2024 18:58

disable component.UseLocalHostAsDefaultHost by default

a013db5

Signed-off-by: Benedikt Bongartz <[email protected]>

frzifus force-pushed the prepare-0.104.0 branch from 4c270c4 to a013db5 Compare July 17, 2024 20:49

frzifus mentioned this pull request Jul 17, 2024

Create a separate bundle for OpenShift installations #3056

Merged

jaronoff97 approved these changes Jul 17, 2024

View reviewed changes

iblancasa approved these changes Jul 18, 2024

View reviewed changes

pavolloffay reviewed Jul 18, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

frzifus commented Jul 18, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

5ea04e3

frzifus commented Jul 18, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

9aabbaf

pavolloffay approved these changes Jul 18, 2024

View reviewed changes

pavolloffay merged commit a9251b3 into open-telemetry:main Jul 18, 2024
33 checks passed

frzifus deleted the prepare-0.104.0 branch July 18, 2024 11:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prepare release 0.104.0 #3119

Prepare release 0.104.0 #3119

frzifus commented Jul 10, 2024 •

edited

Loading

pavolloffay commented Jul 10, 2024

pavolloffay Jul 10, 2024

frzifus Jul 10, 2024

swiatekm Jul 10, 2024

swiatekm left a comment

frzifus commented Jul 11, 2024 •

edited

Loading

pavolloffay left a comment

pavolloffay Jul 11, 2024

pavolloffay Jul 11, 2024

frzifus Jul 11, 2024

pavolloffay Jul 12, 2024

frzifus commented Jul 11, 2024

jaronoff97 Jul 12, 2024

frzifus commented Jul 13, 2024

frzifus commented Jul 15, 2024

pavolloffay commented Jul 15, 2024

pavolloffay left a comment

pavolloffay Jul 15, 2024

pavolloffay Jul 16, 2024

pavolloffay commented Jul 17, 2024

jaronoff97 Jul 17, 2024

jaronoff97 Jul 17, 2024

frzifus Jul 17, 2024

jaronoff97 Jul 17, 2024

frzifus Jul 17, 2024

jaronoff97 Jul 17, 2024

frzifus Jul 17, 2024 •

edited

Loading

jaronoff97 Jul 17, 2024

frzifus Jul 17, 2024


		### Components

		* [OpenTelemetry Collector - v0.104.0](https://github.com/open-telemetry/opentelemetry-collector/releases/tag/v0.104.0)

	TAUnifiyEnvVarExpansion(otelcol)
	TAUnifyEnvVarExpansion(otelcol)

Prepare release 0.104.0 #3119

Prepare release 0.104.0 #3119

Conversation

frzifus commented Jul 10, 2024 • edited Loading

pavolloffay commented Jul 10, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

swiatekm left a comment

Choose a reason for hiding this comment

frzifus commented Jul 11, 2024 • edited Loading

pavolloffay left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

frzifus commented Jul 11, 2024

Choose a reason for hiding this comment

frzifus commented Jul 13, 2024

frzifus commented Jul 15, 2024

pavolloffay commented Jul 15, 2024

pavolloffay left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pavolloffay commented Jul 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

frzifus Jul 17, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

frzifus commented Jul 10, 2024 •

edited

Loading

frzifus commented Jul 11, 2024 •

edited

Loading

frzifus Jul 17, 2024 •

edited

Loading