Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FOSSA scanning workflow #6366

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

opentelemetrybot
Copy link
Collaborator

@opentelemetrybot opentelemetrybot requested a review from a team as a code owner February 18, 2025 03:47
@tiffany76
Copy link
Contributor

@chalin - I think this one's for you.

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@trask - is this to be expected after your second round to enabling FOSSA?

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trask - is this to be expected after your second round to enabling FOSSA?

yep!

@chalin chalin added the CI/infra CI & infrastructure label Feb 21, 2025
@chalin chalin added this pull request to the merge queue Feb 21, 2025
Merged via the queue into open-telemetry:main with commit e2f863d Feb 21, 2025
18 checks passed
Comment on lines +11 to +14
jobs:
fossa:
runs-on: ubuntu-latest
steps:
Copy link
Contributor

@chalin chalin Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trask - this should probably be guarded by a condition testing that we're in the OTel org. WDYT? Because I'm getting errors now from my fork, and I assume that others are too: https://github.com/chalin/opentelemetry.io/actions/runs/13508051895

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github forks have actions turned off by default these days, so I suspect this isn't needed across OTel, but if you need it in this repo that's no problem

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting a bunch of failed FOSSA jobs, one for each of my forked OTel org repos. Here's another: https://github.com/chalin/semantic-conventions/actions/runs/13508298687.

I was asking because I wondered if that workflow content was something we (OTel folks) had control over. If so, can we add the check for the org?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious, why do you run github actions on your semconv fork?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that I turned those on. Maybe PR checks are useful? Anyhow, I can certainly turn off the workflow across my OTel repo forks, but I figured that I might not be the only one in this situation. So my reasoning was: why not "fix" the issue at its source?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants