Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FOSSA scanning workflow #6366

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Add FOSSA scanning workflow #6366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/workflows/fossa.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name: FOSSA scanning

on:
push:
branches:
- main

permissions:
contents: read

jobs:
fossa:
runs-on: ubuntu-latest
steps:
Comment on lines +11 to +14
Copy link
Contributor

@chalin chalin Feb 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trask - this should probably be guarded by a condition testing that we're in the OTel org. WDYT? Because I'm getting errors now from my fork, and I assume that others are too: https://github.com/chalin/opentelemetry.io/actions/runs/13508051895

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github forks have actions turned off by default these days, so I suspect this isn't needed across OTel, but if you need it in this repo that's no problem

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting a bunch of failed FOSSA jobs, one for each of my forked OTel org repos. Here's another: https://github.com/chalin/semantic-conventions/actions/runs/13508298687.

I was asking because I wondered if that workflow content was something we (OTel folks) had control over. If so, can we add the check for the org?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious, why do you run github actions on your semconv fork?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that I turned those on. Maybe PR checks are useful? Anyhow, I can certainly turn off the workflow across my OTel repo forks, but I figured that I might not be the only one in this situation. So my reasoning was: why not "fix" the issue at its source?

- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

- uses: fossas/fossa-action@93a52ecf7c3ac7eb40f5de77fd69b1a19524de94 # v1.5.0
with:
api-key: ${{secrets.FOSSA_API_KEY}}
team: OpenTelemetry
Loading