feat: theorems for ushiftRight
#33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mhk119 I just pushed to the PR, and broke the proof strategy down into smaller chunks so it's easier to upstream. Let me know what you think, and if you're happy with the PR. |
This looks good ! |
Comment on lines
+38
to
+39
| theorem shiftRight_zero (n : Int) : n >>> 0 = n := by | ||
| simp [Int.shiftRight_eq_div_pow] |
|
|
||
| /-- | ||
| Unsigned shift right by at least one bit makes the value of the bitvector less than or equal to `2^(w-1)`, | ||
| makes the interpretation of the bitvector `Int` and `Nat` agree. |
There was a problem hiding this comment.
makes the two times in a row is grammatically suspicious.
| have := show 2 * x.toNat >>> n < 2 ^ w by | ||
| omega | ||
| omega | ||
| · have : x.toNat >>> n = 0 := by |
There was a problem hiding this comment.
Can this be simplified with ushiftRight_eq_zero?
|
@bollu, can this be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.