Enable list of absolute urls in s3-to-dc #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ke product optional in s3-to-dc
for more information, see https://pre-commit.ci
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #584 +/- ##
===========================================
+ Coverage 76.06% 76.52% +0.46%
===========================================
Files 41 41
Lines 2954 2978 +24
===========================================
+ Hits 2247 2279 +32
+ Misses 707 699 -8 ☔ View full report in Codecov by Sentry. |
benjimin
approved these changes
Nov 15, 2023
omad
requested changes
Nov 16, 2023
| @@ -48,7 +48,7 @@ dependencies: | |||
| - sphinx-autodoc-typehints | |||
| - nbsphinx | |||
|
|
|||
| - pip=20 | |||
| - pip=23 | |||
| - pip: | |||
| # odc.apps.dc-tools | |||
| - thredds-crawler | |||
There was a problem hiding this comment.
Don't change it in this PR, but all of thredds-crawler, rio-stac and jupyter-ui-poll are available from conda-forge, so should be installed from there.
There was a problem hiding this comment.
Is there a reason not to change it now?
There was a problem hiding this comment.
In case it makes tests fail, or otherwise complicates a pleasantly straightforward PR. :)
omad
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
click.ClickExceptioninstead ofclick.Abort, which doesn't support a custom error message.odc-tools-tests