Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable list of absolute urls in s3-to-dc #584

Merged
merged 12 commits into from
Nov 16, 2023

fix docstring, rename uri to uris and remove str type

7ba48f0
Select commit
Loading
Failed to load commit list.
Merged

Enable list of absolute urls in s3-to-dc #584

fix docstring, rename uri to uris and remove str type
7ba48f0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 16, 2023 in 0s

76.52% (target 50.00%)

View this Pull Request on Codecov

76.52% (target 50.00%)

Details

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (2d20db7) 76.06% compared to head (7ba48f0) 76.52%.

Files Patch % Lines
apps/dc_tools/odc/apps/dc_tools/s3_to_dc.py 77.27% 5 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #584      +/-   ##
===========================================
+ Coverage    76.06%   76.52%   +0.46%     
===========================================
  Files           41       41              
  Lines         2954     2978      +24     
===========================================
+ Hits          2247     2279      +32     
+ Misses         707      699       -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov