Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CR and CRBs to TestMCADRay test for CI testing #157

Conversation

ChristianZaccaria
Copy link
Contributor

Description

How Has This Been Tested?

  • I'll run the test locally.

Copy link

openshift-ci bot commented Nov 14, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign astefanutti for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -96,3 +108,63 @@ func TestMCADRay(t *testing.T) {
test.Eventually(cfosupport.AppWrappers(test, namespace), cfosupport.TestTimeoutLong).
Should(HaveLen(0))
}

func CreateClusterRoleBinding(t cfosupport.Test, serviceAccount *corev1.ServiceAccount, role *rbacv1.ClusterRole) *rbacv1.ClusterRoleBinding {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these functions have been added to the common module with project-codeflare/codeflare-common#10.

Copy link

openshift-ci bot commented Nov 14, 2023

@ChristianZaccaria: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-odh-dw 4ceef15 link true /test e2e-odh-dw

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ChristianZaccaria
Copy link
Contributor Author

Closing as the odh/cfo CI tests are now taken directly from odh/cfo as opposed from distributed-workloads repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants