Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove trailing comma that made catalog-info.yaml invalid yaml #291

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

pomegranited
Copy link
Contributor

Description: Fix to the catalog-info.yaml file added by #287

cf openedx/edx-submissions#234

Testing instructions: N/A

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped - N/A
  • Changelog record added - N/A
  • Documentation updated (not only docstrings) - N/A
  • Commits are squashed

Post merge:

  • Create a tag - N/A
  • Check new version is pushed to PyPi after tag-triggered build is finished. - N/A
  • Delete working branch (if not needed anymore)

@sarina
Copy link
Contributor

sarina commented Apr 4, 2024

@e0d still stuck 😢

@pomegranited
Copy link
Contributor Author

@e0d @sarina This isn't the only PR on this repo experiencing this issue:

It works for #279, but that PR was updated before I merged #287 last week, which added catalog-info.yml.

I can't see how the cla checks work, but do they use Backstage at all? Is it possible that they're failing because of the typo this PR is trying to fix?

@sarina
Copy link
Contributor

sarina commented Apr 5, 2024

I pinged the team, so will hope to have an answer tomorrow. :\

@pomegranited pomegranited enabled auto-merge (squash) April 5, 2024 00:12
@feanil
Copy link
Contributor

feanil commented Apr 5, 2024

The check is failing because the catalog-info.yaml file is mis-formatted, I've verified that Jill has a valid CLA right now so I'm gonna override the check and merge this.

@pomegranited pomegranited merged commit ec89067 into master Apr 5, 2024
16 checks passed
@pomegranited pomegranited deleted the jill/fix-catalog-comma branch April 5, 2024 14:52
@feanil
Copy link
Contributor

feanil commented Apr 5, 2024

@pomegranited CLA check sholud work correctly on other PRs now, you may need to add a comment or update the title to get it to run again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants