Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pin event-tracking for pymongo 4.4.0 support #433

Merged
merged 1 commit into from
Jul 16, 2024
Merged

fix: pin event-tracking for pymongo 4.4.0 support #433

merged 1 commit into from
Jul 16, 2024

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Jul 11, 2024

Description:

Pins event-tracking to a version before installing pymongo 4.4.0 which is not supported on edx-platform.

See openedx/tutor-contrib-aspects#891, openedx/event-routing-backends#436, openedx/completion#305 for more information.

Merge checklist:

  • All reviewers approved
  • CI build is green
  • If adding new checks, followed how_tos/0001-adding-new-checks.rst
  • Changelog record added (if needed)
  • Documentation updated (not only docstrings) (if needed)
  • Commits are squashed

@openedx-webhooks
Copy link

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 11, 2024
@pomegranited pomegranited mentioned this pull request Jul 11, 2024
Closed
@bmtcril
Copy link

bmtcril commented Jul 15, 2024

I think this is the right solution until openedx/edx-platform#34675 lands, does that make sense to you @mumarkhan999 ? @feanil is looking at the issues with commitlint on this repo currently.

@feanil
Copy link
Contributor

feanil commented Jul 15, 2024

Commitlint issue should be fixed if you rebase off the latest master branch.

@Ian2012 Ian2012 force-pushed the cag/event-tracking branch 2 times, most recently from 415754f to 208ad92 Compare July 16, 2024 16:16
feanil
feanil reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion for extra context on when this can be unpinned.

edx_lint/files/common_constraints.txt Outdated Show resolved Hide resolved
@Ian2012
Copy link
Contributor Author

Ian2012 commented Jul 16, 2024

@feanil thanks, it's ready for review now

feanil
feanil reviewed Jul 16, 2024
View reviewed changes
edx_lint/files/common_constraints.txt Outdated
# Cause: https://github.com/openedx/event-tracking/pull/290
# event-tracking 2.4.1 upgrades to pymongo 4.4.0 which is not supported on edx-platform.
# We will pin event-tracking to do not break existing installations
# See
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# See
# This can be unpinned once https://github.com/openedx/edx-platform/issues/34586 has been resolved and edx-platform is running with pymong>= 4.4.0

feanil
feanil reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you missed the link.

@feanil feanil merged commit 228b158 into openedx:master Jul 16, 2024
4 checks passed
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feanil feanil feanil approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ian2012 @openedx-webhooks @bmtcril @feanil