fix: event-tracking:2.4.1 clutter with openedx:master

[vahid75]

Description: event-tracking one of this package dependencies, created a new version (openedx/event-tracking#290) which upgraded the PyMongo version. So when we install this package in the old style, we will get the latest event-tracking version with PyMongo 4.4.0 which is incompatible with openedx master.
I've created this PR in response to a tutor-contrib-aspects issue

Dependencies: See the aspects issue

[openedx-webhooks]

Thanks for the pull request, @vahid75!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @ziafazal. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[Ian2012]

Hi @vahid75, thanks for your contribution. Can you bump the version and change the commit message?

@bmtcril Do you think this should be pinned here or on the tutor-contrib-aspects plugin?

[pomegranited]

Hi @Ian2012

@bmtcril Do you think this should be pinned here or on the tutor-contrib-aspects plugin?

This issue is a problem for more than just aspects.. e.g openedx/completion#305 wants to upgrade event-tracking and pymongo too, so not sure what the best course is.

Maybe we need to pin event-tracking in common_constraints until we're ready to upgrade pymongo in edx-platform?

[Ian2012]

@pomegranited I've opened a PR, we still need this, right? As this is not installed alongside the edx-platform requirements.

[pomegranited]

@Ian2012

I've opened a PR

openedx/edx-lint#433 -- thank you! I'm not exactly sure what magic makes this change propagate around to the various repos, but this looks like the right place to make the change.

we still need this, right? As this is not installed alongside the edx-platform requirements.

Ah yep, we're not using common_constraints.txt for this repo, so yep, we need #436 too.

[bmtcril]

I think the edx-lint PR is the way to go until the edx-platform change lands. We do us common-constraints here: https://github.com/openedx/event-routing-backends/blob/master/requirements/constraints.txt

[vahid75]

Hi @vahid75, thanks for your contribution. Can you bump the version and change the commit message?

@bmtcril Do you think this should be pinned here or on the tutor-contrib-aspects plugin?

hi @Ian2012 , sorry for my delay. I have changed my commit message to meet the conventional commit messaging. But about the bumping version could you please help me? I'm really new to this project and don't know how to do that

[Ian2012]

@vahid75 you need to change the version here for a fix: https://github.com/openedx/event-routing-backends/blob/master/event_routing_backends/__init__.py#L5: 9.3.1 and add a changelog entry here: https://github.com/openedx/event-routing-backends/blob/master/CHANGELOG.rst, you can use your commit message.

[bmtcril]

I don't think this is necessary, the update to edx-lint effectively pinned this as you can see here: #440 . The docs errors are unrelated, but I think the way forward is to fix that PR instead of pinning this in two places.

[mphilbrick211]

@bmtcril @vahid75 @Ian2012 - is this still being pursued?

[vahid75]

@bmtcril @vahid75 @Ian2012 - is this still being pursued?

They handled it by changing it on edx-lint repo.

[Ian2012]

This is causing issues for people using Aspects on older platform versions as it installs an incompatible event-tracking version. We still need this, what do you think @bmtcril @ziafazal ?

[ziafazal]

@vahid75 @Ian2012 I don't think we need this change here because it is handled in common constraints here already.

[Ian2012]

Closing it now

[openedx-webhooks]

@vahid75 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.