-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds TenantAwareLinkRenderStarted filter #32014
feat: adds TenantAwareLinkRenderStarted filter #32014
Conversation
Thanks for the pull request, @JuanDavidBuitrago! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. |
0f5f3bb
to
3bd613b
Compare
Hi @JuanDavidBuitrago! Just checking in to see if you plan to look into the failing tests? Once all checks are green, we can get this reviewed for you. Thanks! |
77933a5
to
e74f948
Compare
Hi @mphilbrick211! I had to make a temporal change in requirement to pass the test, but Thanks for your time! |
Hi @mariajgrimaldi and @felipemontoya, Could you review this? |
e74f948
to
352fb07
Compare
Hi @JuanDavidBuitrago! Just following up on this :) |
@mphilbrick211: I spoke internally with @JuanDavidBuitrago's team, and they told me they didn't have the capacity to take this on right now. I'll move this PR to draft to give them time to work on it. Thanks! |
Hi @mphilbrick211 @mariajgrimaldi, thank you for your patience. |
Closing this for now. We can reopen in the future if needed. Thanks! |
@JuanDavidBuitrago Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR introduces a new openedx-filters event
org.openedx.learning.tenant_aware_link.render.started.v1
. This is implemented to guaranty multi tenancy in eox-tenant in LMS_ROOT_URL from Studio to LMS, but eox-tenant is only an example would consider use.Impact by the change on:
Supporting information
There are not openedx related tickets. The related PR are:
Testing instructions
The change can be tested with testing instructions in eox-tenant plugin.
Deadline
"None"
Other information
Warning: Once accepted this PR, it has to be merged only after openedx/openedx-filters#77 is merged and the requirements in this PR are updated.
Settings