Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds LmsUrlCreationStarted filter #35142

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jignaciopm
Copy link

Description

This PR introduces a new openedx-filters event org.openedx.course_authoring.lms.url.creation.started.v1. This is implemented to guaranty multi tenancy in eox-tenant in LMS_ROOT_URL from Studio to LMS, but eox-tenant is only an example would consider use.

Impact by the change on:

cms/djangoapps/contentstore/views/assets.py
common/djangoapps/util/course.py

Supporting information

There are not openedx related tickets. The related PR are:

openedx/openedx-filters#200
eduNEXT/eox-tenant#179

Testing instructions

The change can be tested with testing instructions in eduNEXT/eox-tenant#179.

Deadline

"None"

Other information

⚠️

Warning: Once accepted this PR, it has to be merged only after openedx/openedx-filters#77 is merged and the requirements in this PR are updated.

⚠️

Settings

EDXAPP_EXTRA_REQUIREMENTS:
  - name: git+https://github.com/eduNEXT/eox-tenant.git@JDB/add_tenant_aware_filter

@openedx-webhooks
Copy link

Thanks for the pull request, @jignaciopm!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 19, 2024
@jignaciopm jignaciopm force-pushed the jipm/add_tenant_aware_filter branch 2 times, most recently from 51bfa7a to 9995472 Compare July 19, 2024 15:04
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 24, 2024
@mphilbrick211
Copy link

Hi @jignaciopm! Just flagging there are some failing checks here.

@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 25, 2024
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Aug 23, 2024
@e0d
Copy link
Contributor

e0d commented Sep 6, 2024

@jignaciopm Looks like there's a failed check.

@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Sep 9, 2024
@mariajgrimaldi
Copy link
Member

Hey, @jignaciopm, thanks for contributing this! Those testing instructions are a bit out of date. Could you please include them directly in the cover letter, update and simplify them? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Waiting on Author
Development

Successfully merging this pull request may close these issues.

5 participants