Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: find proper courses when searching with active/archived filters on #1497

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: find proper courses when searching with active/archived filters on #1497

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/studio-home/tabs-section/courses-tab/courses-filters/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ const CoursesFilters = ({

const handleSearchCoursesDebounced = useCallback(
debounce((value) => handleSearchCourses(value), 400),
[],
[activeOnly, archivedOnly],
Copy link
Contributor

@bradenmacdonald bradenmacdonald Nov 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question: should order not be included as well ?

Copy link
Member

@mariajgrimaldi mariajgrimaldi Nov 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, going back to this fix that addressed this issue in particular about the sorting default, after searching even if sorting is set to "newest" or "oldest" the results are returned sorted only by display name. Could that be fixed by adding order here?

);

return (
Expand Down