fix: find proper courses when searching with active/archived filters on

[bra-i-am]

Description

This PR makes the Studio Home search bar work as expected when are applied archived/active filters. When users attempt to filter for active/archived in combination with the search input, the proper courses are displayed.

• courses-filters/index.jsx: It was added the filter states to the useCallback dependencies so if any of this filters changes, they are applied properly and retrieved the proper data

Supporting information

GitHub Issue: #1477

Testing instructions

Make sure you count on at least one course and do the following:

1. Mount this branch on the frontend-app-authoring MFE to test it
2. Go to the Studio Home, you'll watch all your courses
3. Now apply the filter Archived in the dropdown beside the search bar
4. Try to look for a course you know is active, but if everything goes well, you shouldn't be able to find it
5. The same must happen if you have activated the filter Active and try to look for an archived course
6. Make sure you are shown the message "We could not find any results."

[openedx-webhooks]

Thanks for the pull request, @bra-i-am!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.01%. Comparing base (9b4cf87) to head (d5692e5).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1497   +/-   ##
=======================================
  Coverage   93.01%   93.01%           
=======================================
  Files        1048     1048           
  Lines       20480    20480           
  Branches     4402     4401    -1     
=======================================
  Hits        19049    19049           
  Misses       1361     1361           
  Partials       70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mariajgrimaldi]

@arbrandes @bradenmacdonald: could you give us a hand reviewing this PR? It fixes #1477. Thank you!

[bradenmacdonald]

Just one question: should order not be included as well ?

[mariajgrimaldi]

Also, going back to this fix that addressed this issue in particular about the sorting default, after searching even if sorting is set to "newest" or "oldest" the results are returned sorted only by display name. Could that be fixed by adding order here?