-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FC-0056] Course outline sidebar #1342
Conversation
Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. |
* feat: [AXIMST-572] create course-outline sidebar * fix: [AXIMST-572] after review
* feat: [AXIMST-617] display section and sequence sidebar level * fix: after review * fix: after review
* feat: [AXIMST-590] display units on sidebar, two tier layout * fix: expand prop-types * fix: after review
* feat: [AXIMST-578] display outline sidebar depends on feature flag * fix: after review
* feat: [AXIMST-635] display discussions sidebar by waffle flag * fix: after demo * fix: after review * fix: upstream failed tests
* feat: [AXIMST-641] display special exam label and unit lock icon * fix: after backend changes * fix: error with entrance exam * fix: after review
* feat: make sidebar fixed on scroll and add tests * fix: extend tests * fix: tests * fix: codecov * fix: after review
d315c9c
to
9e46bf1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1342 +/- ##
==========================================
+ Coverage 88.24% 88.68% +0.44%
==========================================
Files 293 311 +18
Lines 4992 5234 +242
Branches 1266 1330 +64
==========================================
+ Hits 4405 4642 +237
- Misses 571 576 +5
Partials 16 16 ☔ View full report in Codecov by Sentry. |
…plete subsection (#28) * fix: [AXIMST-748] update outline sidebar for locked subsection on complete subsection * fix: tests * fix: after review
* feat: [AXIMST-770] add indent for Units in the NavBar * fix: after demo
Hey @jmakowski1123, since this is for an FC project with status In Development, can we consider it approved from the product perspective? Same question for other PRs related to the FC-0056 project. |
* feat: [AXIMST-708] hide horizontal navigation in units * fix: after review * fix: [AXIMST-708] fix typo --------- Co-authored-by: ihor-romaniuk <[email protected]>
@jmakowski1123 just following up on this :) |
@mphilbrick211 - If this pull request just represents the Phase 1 portion of the project, which has been tested, then yes, this has been approved by Product. The Phase 2 of the FC has yet to be tested by product. @GlugovGrGlib - does this pull request just represent the Phase 1 portion of the project? |
@crathbun428 yes, all FC-0056 PR, that are currently opened to openedx repositories are part of the phase 1 |
@GlugovGrGlib - Excellent - thank you for confirming. @mphilbrick211 - We can consider this approved by product. Please let me know if you have any follow-up questions! |
Thanks @crathbun428 @GlugovGrGlib @mphilbrick211 for sorting this out. |
@ihor-romaniuk Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
The main PR about the course outline sidebar functionality #1349 |
Settings
Description
This pull request adds an important feature to our platform: displaying a navigation sidebar within a given course.
Design
https://www.figma.com/file/gew5tORDX4Q7wxOS8vjqZu/side-nav-OEX?type=design&node-id=318-3234&mode=design&t=rBe1ToNYP8RY6QOp-0
Testing instructions