feat: [FC-0056] courseware sidebar enhancement

[ihor-romaniuk]

Settings

EDX_PLATFORM_REPOSITORY: https://github.com/openedx/edx-platform.git
EDX_PLATFORM_VERSION: master

TUTOR_GROVE_WAFFLE_FLAGS:
  - name: courseware.enable_navigation_sidebar
    everyone: true

Description

This pull request adds several improvements to the courseware sidebar navigation.

• Display section and sequence progress
• Add tracking event to the unit button
• Hide the horizontal unit navigation with enabled sidebar navigation

Related PRs

• [backport] redwood feat: [FC-0056] courseware sidebar enhancement [redwood] #1398

Depends on BE PRs

• feat: [FC-0056] Add calculation for percentage of the completions units progress

Design

https://www.figma.com/file/gew5tORDX4Q7wxOS8vjqZu/side-nav-OEX?type=design&node-id=318-3234&mode=design&t=rBe1ToNYP8RY6QOp-0

Testing instructions

1. Run master devstack.
2. Start platform make dev.up.lms+cms+frontend-app-course-authoring and make checkout on this branch.
3. Go to Course Unit page from the Course Outline page.

[openedx-webhooks]

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[codecov]

Codecov Report

Attention: Patch coverage is 82.69231% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 88.66%. Comparing base (257c9dc) to head (b13de55).
Report is 7 commits behind head on master.

❗ Current head b13de55 differs from pull request most recent head d28f1bb

Please upload reports for the commit d28f1bb to get more accurate results.

Files	Patch %	Lines
...sidebars/course-outline/components/SidebarUnit.jsx	18.18%	9 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1386      +/-   ##
==========================================
- Coverage   88.74%   88.66%   -0.09%     
==========================================
  Files         303      307       +4     
  Lines        5224     5266      +42     
  Branches     1330     1338       +8     
==========================================
+ Hits         4636     4669      +33     
- Misses        572      581       +9     
  Partials       16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[open-craft-grove]

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

[open-craft-grove]

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

[itsjeyd]

Adding product review complete label here, based on #1342 (comment).

CC @crathbun428 @mphilbrick211 @GlugovGrGlib

[itsjeyd]

@ihor-romaniuk Thanks for these changes.

It looks like codecov is failing right now. Once that's sorted out we should be good to start engineering review.

EDIT: Actually, we might need to wait for openedx/edx-platform#34816 to get merged?

[open-craft-grove]

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

[open-craft-grove]

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

[arbrandes]

Looks great, works great! Thanks!

[arbrandes]

I'm rerunning tests before merging.

[openedx-webhooks]

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

[arbrandes]

Running into token issues for coverage. Let's deal with that separately.